-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OKD-103: Build the machine-os-images image for OKD/SCOS #36453
Conversation
@LorbusChris: This pull request references OKD-103 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@LorbusChris: the
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
You need to run |
|
/pj-rehearse ack |
/cc @dtantsur @elfosardo |
/approve |
The OKD installer from the `origin` namespace has to be used in the build in order to actually pull the FCOS bootimage. Fixes: okd-project/okd#1506
@LorbusChris: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
1 similar comment
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, lmzuccarelli, LorbusChris, sherine-k, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
inputs: | ||
ocp_4.12_installer: | ||
as: | ||
- registry.ci.openshift.org/ocp/4.12:installer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- registry.ci.openshift.org/ocp/4.12:installer | |
- registry.ci.openshift.org/origin/scos-4.12:installer |
inputs: | ||
ocp_4.13_installer: | ||
as: | ||
- registry.ci.openshift.org/ocp/4.13:installer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- registry.ci.openshift.org/ocp/4.13:installer | |
- registry.ci.openshift.org/origin/scos-4.13:installer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this replace https://github.com/openshift/machine-os-images/blob/main/Dockerfile#L1 and is correct here?
inputs: | ||
ocp_4.13_installer: | ||
as: | ||
- registry.ci.openshift.org/ocp/4.13:installer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- registry.ci.openshift.org/ocp/4.13:installer | |
- registry.ci.openshift.org/origin/scos-4.13:installer |
@LorbusChris: Updated the following 7 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also fixes: okd-project/okd#1506
/cc @vrutkovs @derekhiggins