Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable to CI config #43084

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add environment variable to CI config #43084

merged 1 commit into from
Mar 20, 2024

Conversation

brucejcong
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Contributor

@brucejcong, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: failed to load registry file /var/tmp/gitrepo3152710167/ci-operator/step-registry/hypershift/aws/run-e2e/hypershift-aws-run-e2e-chain.yaml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal bool into Go struct field StepDependency.chain.steps.dependencies.name of type string
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2023
@brucejcong
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2023
@stevekuznetsov
Copy link
Contributor

/retest
/pj-rehearse

@sjenning
Copy link
Contributor

sjenning commented Nov 3, 2023

/hold
Why do we want to disable PKI on the AWS flow?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023
@brucejcong
Copy link
Contributor Author

Hey @sjenning from my understanding, this is to address this issue here: openshift/hypershift#2455. According to Hide after convos with Cesar, this would help in extending the CI tests.

From my understanding, this should catch if any PKI contracts has been broken on patch updates, but let me know if there's anything I'm missing! This PR goes with it: openshift/hypershift#2989

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 7, 2023
@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 22, 2023
@openshift-bot
Copy link
Contributor

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jan 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brucejcong
Copy link
Contributor Author

/reopen

@openshift-ci openshift-ci bot reopened this Feb 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@brucejcong: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brucejcong
Copy link
Contributor Author

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 13, 2024
@brucejcong
Copy link
Contributor Author

/pj-rehearse

@brucejcong brucejcong mentioned this pull request Feb 13, 2024
Open
@csrwng
Copy link
Contributor

csrwng commented Feb 13, 2024

@brucejcong The thinking was to disable PKI reconciliation on upgrade for branches != main

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024 •
edited
Loading

@brucejcong: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hypershift/release-4.15/e2e-aws-4-13 acff38c link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.15-e2e-aws-4-13
ci/rehearse/openshift/hypershift/release-4.14/e2e-aws acff38c link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.14-e2e-aws
ci/rehearse/openshift/hypershift/release-4.16/e2e-aws-4-13 acff38c link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.16-e2e-aws-4-13
ci/rehearse/openshift/hypershift/release-4.16/e2e-aws-4-12 acff38c link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.16-e2e-aws-4-12
ci/rehearse/openshift/hypershift/release-4.16/e2e-aws acff38c link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.16-e2e-aws
ci/rehearse/openshift/hypershift/release-4.15/e2e-aws acff38c link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.15-e2e-aws
ci/rehearse/openshift/hypershift/release-4.15/e2e-aws-4-12 acff38c link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.15-e2e-aws-4-12
ci/rehearse/openshift/hypershift/release-4.17/e2e-aws-4-12 e1997f4 link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.17-e2e-aws-4-12
ci/rehearse/openshift/hypershift/main/e2e-aws-4-13 e1997f4 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-4-13
ci/rehearse/openshift/hypershift/release-4.17/e2e-aws e1997f4 link unknown /pj-rehearse pull-ci-openshift-hypershift-release-4.17-e2e-aws
ci/rehearse/openshift/hypershift/main/e2e-aws e1997f4 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws
ci/rehearse/openshift/hypershift/main/e2e-aws-4-12 e1997f4 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-4-12

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@csrwng
Copy link
Contributor

csrwng commented Mar 8, 2024

@brucejcong you'll need to add the env var to

release/ci-operator/step-registry/hypershift/aws/run-e2e/hypershift-aws-run-e2e-chain.yaml

Line 24 in 5a157e4

env:

and default it to "false"

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@brucejcong: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-release-4.14-e2e-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.13-e2e-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.15-e2e-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.12-e2e-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-aws-4-12 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-aws-4-13 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-aws-4-12 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-aws-4-13 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.16-e2e-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.16-e2e-aws-4-12 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.16-e2e-aws-4-13 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.15-e2e-aws-4-12 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.15-e2e-aws-4-13 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.14-e2e-aws-4-12 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.14-e2e-aws-4-13 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.13-ho-latest-e2e-aws openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.13-e2e-aws-4-12 openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.12-ho-4.13-e2e-aws openshift/hypershift presubmit Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@csrwng
Copy link
Contributor

csrwng commented Mar 20, 2024

/approve

@csrwng
Copy link
Contributor

csrwng commented Mar 20, 2024

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brucejcong, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csrwng
Copy link
Contributor

csrwng commented Mar 20, 2024

/hold cancel
This is to test that no new PKI is introduced in previous minor releases.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@csrwng
Copy link
Contributor

csrwng commented Mar 20, 2024

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fa18136 into openshift:master Mar 20, 2024
18 checks passed
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
@brucejcong @BradLugo
Add environment variable to CI config (openshift#43084)
a7fb287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brucejcong @openshift-ci-robot @openshift-bot @stevekuznetsov @sjenning @csrwng