Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28230: enforce termination message policy on all platform pods #50875

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 12, 2024

save the last few lines of the log into the API whe the container crashes.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 12, 2024
@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request references Jira Issue OCPBUGS-28230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

save the last few lines of the log into the API whe the container crashes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 12, 2024
@openshift-ci openshift-ci bot requested review from stbenjam and xueqzhan April 12, 2024 18:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@deads2k: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ironic-static-ip-manager-release-4.7-e2e-metal-ipi openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.6-e2e-metal-ipi openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.5-e2e-metal-ipi openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-master-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.17-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.16-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.15-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.14-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.13-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.12-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.11-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.10-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.9-e2e-metal-ipi-ovn-dualstack openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-master-e2e-metal-ipi-bm openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.17-e2e-metal-ipi-bm openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.16-e2e-metal-ipi-bm openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-master-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.17-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.16-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.15-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.14-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.13-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.12-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.11-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed
pull-ci-openshift-ironic-static-ip-manager-release-4.10-e2e-metal-ipi-ovn-ipv6 openshift/ironic-static-ip-manager presubmit Registry content changed

A total of 16602 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@deads2k
Copy link
Contributor Author

deads2k commented Apr 15, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@deads2k: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@deads2k, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build05: failed waiting for imagestreamtag origin/scos-4.16:upi-installer to appear: get failed: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline

If the problem persists, please contact Test Platform.

@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Apr 15, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@deads2k: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3c41c4b into openshift:master Apr 15, 2024
16 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@deads2k: Jira Issue OCPBUGS-28230: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28230 has not been moved to the MODIFIED state.

In response to this:

save the last few lines of the log into the API whe the container crashes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants