Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update aws frequency #54056

Merged
merged 1 commit into from
Jul 12, 2024
Merged

update aws frequency #54056

merged 1 commit into from
Jul 12, 2024

Conversation

qiliRedHat
Copy link
Contributor

@qiliRedHat qiliRedHat commented Jul 5, 2024 •
edited
Loading

Updated the frequency after 4.16 GA to doc https://docs.google.com/document/d/1NbXwfZwSkMdftuKW1Ob705rQk-XHLtPtP1d1vuqF9Vo. According to the doc.

  1. Update 4.16 aws jobs from weekly to bi-weekly
  2. Update 4.14 aws jobs from b-weekly to monthly
    Loaded-upgrade
  3. Disable 4.12 to 4.13 loaded upgrade, and 4.12 to 4.13 to 4.14 loaded upgrade
  4. Disable 120 and 252 nodes loaded upgrade from 4.15 to 4.16
  5. Added 4.16 to 4.17 jobs, 24 nodes weekly, 120 and 252 nodes monthly
  6. Added 4.15 to 4.16 24 nodes bi-weekly job
  7. Added 4.13 to 4.14 24 nodes monthly job

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@openshift-ci openshift-ci bot requested review from memodi and paigerube14 July 5, 2024 10:23
@paigerube14
Copy link
Contributor

Looks good, but will let Andrew do review for day/time distribution

@qiliRedHat qiliRedHat force-pushed the aws-post-416GA branch 5 times, most recently from 3ae9e64 to 2458561 Compare July 8, 2024 10:28
@qiliRedHat
Copy link
Contributor Author

@afcollins PTAL

afcollins
afcollins reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@afcollins afcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked them all. Couple of comments

@qiliRedHat
Copy link
Contributor Author

@afcollins I updated according to your comments.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@qiliRedHat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.13-nightly-x86-loaded-upgrade-from-4.12-loaded-upgrade-412to413-5nodes openshift-qe/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-control-plane-etcdencrypt-24nodes openshift-qe/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-loaded-upgrade-from-4.12-loaded-upgrade-412to413to414-5nodes openshift-qe/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-loaded-upgrade-from-4.13-images openshift-qe/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-loaded-upgrade-from-4.15-loaded-upgrade-415to416-120nodes openshift-qe/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-loaded-upgrade-from-4.15-loaded-upgrade-415to416-252nodes openshift-qe/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.17-nightly-x86-loaded-upgrade-from-4.16-images openshift-qe/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.17-nightly-x86-loaded-upgrade-from-4.16-loaded-upgrade-416to417-180nodes openshift-qe/ocp-qe-perfscale-ci presubmit Presubmit changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-data-path-9nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.17-nightly-x86-loaded-upgrade-from-4.16-loaded-upgrade-416to417-252nodes N/A periodic Periodic changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-loaded-upgrade-from-4.15-loaded-upgrade-415to416-24nodes N/A periodic Periodic changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-control-plane-120nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-control-plane-24nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-control-plane-120nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-node-density-heavy-24nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-loaded-upgrade-from-4.13-loaded-upgrade-413to414-24nodes N/A periodic Periodic changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-control-plane-24nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.17-nightly-x86-loaded-upgrade-from-4.16-loaded-upgrade-416to417-120nodes N/A periodic Periodic changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.17-nightly-x86-loaded-upgrade-from-4.16-loaded-upgrade-416to417-24nodes N/A periodic Periodic changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-node-density-heavy-24nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-control-plane-etcdencrypt-24nodes N/A periodic Ci-operator config changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-data-path-9nodes N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@qiliRedHat
Copy link
Contributor Author

@afcollins I updated according to your last 3 comments, and did not do any other new change, please have a review, thank you so much! Hopefully we are good to go!

@qiliRedHat
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 12, 2024
afcollins
afcollins reviewed Jul 12, 2024
View reviewed changes
...ci/openshift-qe-ocp-qe-perfscale-ci-main__aws-4.17-nightly-x86-loaded-upgrade-from-4.16.yaml
workflow: openshift-qe-upgrade
timeout: 8h0m0s
- as: loaded-upgrade-416to417-252nodes
cron: 0 6 24 * *
Copy link
Contributor

@afcollins afcollins Jul 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not crazy about this one running (which would take ~6 hours) and then loaded-upgrade-415to416-24nodes starting at 9a on the same day.

Generally any 252 node runs we may want to block an exclusive window. But, we may also be fine. Will merge for now and adjust if required.

afcollins
afcollins approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@afcollins afcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you, @qiliRedHat !! Appreciate your diligence and initiative on this.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afcollins, qiliRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c94c3c6 into openshift:master Jul 12, 2024
16 of 17 checks passed
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
@qiliRedHat
update aws jobs post 4.16 GA (openshift#54056)
d4bb400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afcollins afcollins afcollins approved these changes

@memodi memodi Awaiting requested review from memodi

@paigerube14 paigerube14 Awaiting requested review from paigerube14

Assignees

@afcollins afcollins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@qiliRedHat @paigerube14 @openshift-ci-robot @afcollins