Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[must-gather] Rename dockerfile #54073

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 5, 2024

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ashwindasr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-must-gather-master-e2e-aws openshift/must-gather presubmit Ci-operator config changed
pull-ci-openshift-must-gather-master-images openshift/must-gather presubmit Ci-operator config changed
pull-ci-openshift-must-gather-master-okd-scos-images openshift/must-gather presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from jmguzik and sferich888 July 5, 2024 18:12
@soltysh
Copy link

soltysh commented Jul 9, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@soltysh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/must-gather/master/e2e-aws e54e328 link unknown /pj-rehearse pull-ci-openshift-must-gather-master-e2e-aws
ci/rehearse/openshift/must-gather/master/images e54e328 link unknown /pj-rehearse pull-ci-openshift-must-gather-master-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@soltysh
Copy link

soltysh commented Jul 9, 2024

/pj-rehearse skip
they will fail b/c we need openshift/must-gather#432, which relies on this PR, so it's chicken and egg problem.

@openshift-ci-robot
Copy link
Contributor

@soltysh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 9, 2024
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 41c1da6 into openshift:master Jul 9, 2024
16 of 18 checks passed
@ashwindasr ashwindasr deleted the must-gather-rename-dockerfile branch July 9, 2024 15:48
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Jul 9, 2024
ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Jul 10, 2024
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
Neha-dot-Yadav pushed a commit to Neha-dot-Yadav/release that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants