Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-864: Presubmit job to test adding nodes to a cluster #54082

Merged
merged 1 commit into from
Aug 2, 2024
Merged

AGENT-864: Presubmit job to test adding nodes to a cluster #54082

merged 1 commit into from
Aug 2, 2024

Conversation

rwsu
Copy link
Contributor

@rwsu rwsu commented Jul 5, 2024

The job installs a compact cluser and configures two extra worker nodes. The extra worker nodes are added to the cluster after the cluster has been installed.

Depends on: openshift-metal3/dev-scripts#1654

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 5, 2024 •
edited by openshift-ci bot
Loading

@rwsu: This pull request references AGENT-864 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to this:

The job installs a compact cluser and configures two extra worker nodes. The extra worker nodes are added to the cluster after the cluster has been installed.

Depends on: openshift-metal3/dev-scripts#1654

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@rwsu
AGENT-864: Presubmit job to test adding nodes to a cluster
03f73bb 
The job installs a compact cluser and configures two extra worker
nodes. The extra worker nodes are added to the cluster after
the cluster has been installed.

Depends on: openshift-metal3/dev-scripts#1654
@rwsu rwsu marked this pull request as ready for review July 18, 2024 19:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rwsu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-agent-compact-ipv4-add-nodes openshift/installer presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andfasano
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rwsu
Copy link
Contributor Author

rwsu commented Jul 30, 2024

/retest-required

@rwsu
Copy link
Contributor Author

rwsu commented Jul 30, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar pawanpinjarkar mentioned this pull request Jul 30, 2024
Merged
@pawanpinjarkar
Copy link
Contributor

/test e2e-agent-compact-ipv4-add-nodes

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

@pawanpinjarkar: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test build09-dry
  • /test build10-dry
  • /test check-gh-automation
  • /test check-gh-automation-tide
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hosted-mgmt-dry
  • /test jira-lifecycle-config
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test stackrox-stackrox-stackrox-stackrox-check
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test vsphere02-dry
  • /test yamllint

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-check-gh-automation
  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint

In response to this:

/test e2e-agent-compact-ipv4-add-nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawanpinjarkar
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andfasano
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andfasano
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@andfasano
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Contributor

@rwsu looks like the dev-scripts needs a fix ?

+(./agent/07_agent_add_node.sh:42): sudo virt-xml ostest_extraworker_0 --add-device --disk ./node.x86_64.iso,device=cdrom,target.dev=sdc
ERROR    Error: --disk ./node.x86_64.iso,device=cdrom,target.dev=sdc: Size must be specified for non existent volume 'node.x86_64.iso'

@rwsu
Copy link
Contributor Author

rwsu commented Jul 31, 2024

/pj-rehearse

This was addressed in openshift-metal3/dev-scripts#1685

@rwsu
Copy link
Contributor Author

rwsu commented Jul 31, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Contributor

/pj-rehearse

@pawanpinjarkar
Copy link
Contributor

/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-compact-ipv4-add-nodes

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rwsu
Copy link
Contributor Author

rwsu commented Aug 1, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rwsu
Copy link
Contributor Author

rwsu commented Aug 1, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rwsu
Copy link
Contributor Author

rwsu commented Aug 2, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rwsu
Copy link
Contributor Author

rwsu commented Aug 2, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rwsu
Copy link
Contributor Author

rwsu commented Aug 2, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@rwsu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 2, 2024
pawanpinjarkar
pawanpinjarkar reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b6c36cb into openshift:master Aug 2, 2024
18 checks passed
JianLi-RH pushed a commit to JianLi-RH/release that referenced this pull request Aug 5, 2024
@rwsu @JianLi-RH
AGENT-864: Presubmit job to test adding nodes to a cluster (openshift…
633a38d 
…#54082)

The job installs a compact cluser and configures two extra worker
nodes. The extra worker nodes are added to the cluster after
the cluster has been installed.

Depends on: openshift-metal3/dev-scripts#1654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanpinjarkar pawanpinjarkar pawanpinjarkar left review comments

@andfasano andfasano Awaiting requested review from andfasano

Assignees

@pawanpinjarkar pawanpinjarkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwsu @openshift-ci-robot @andfasano @pawanpinjarkar