Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-13537: Add Snyk security scanning #54087

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

natifridman
Copy link
Contributor

Add Snyk security scanning to kube-compare project

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2024

@natifridman: This pull request references CNF-13537 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Add Snyk security scanning to kube-compare project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 7, 2024
Add Snyk security scanning to kube-compare project
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 7, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@natifridman: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kube-compare-main-security openshift/kube-compare presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@natifridman
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@natifridman: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pixelsoccupied
Copy link
Contributor

/lgtm
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@pixelsoccupied: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 7, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2024
Copy link
Contributor

openshift-ci bot commented Jul 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natifridman, pixelsoccupied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2024
Copy link
Contributor

openshift-ci bot commented Jul 7, 2024

@natifridman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c05927f into openshift:master Jul 7, 2024
18 checks passed
@natifridman natifridman deleted the snyk branch July 8, 2024 06:08
ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Jul 10, 2024
Add Snyk security scanning to kube-compare project
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
Add Snyk security scanning to kube-compare project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants