-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RBACs for ci-operator to get/list secrets from the ci namespace #55193
Add RBACs for ci-operator to get/list secrets from the ci namespace #55193
Conversation
/cc @droslean |
@psalajova,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
- get | ||
- list | ||
|
||
- kind: ClusterRoleBinding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will allow the ci-operator
service account to get/list secrets from all namespaces. Instead, we need to restrict it to the ci namespace.
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, psalajova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@psalajova: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Needed for openshift/ci-tools#4112