SDN-5346: ovn-kubernetes, virt: add new AWS virt lane to run OVN presubmits #57704
Conversation
maiqueb
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@maiqueb: This pull request references SDN-5346 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@maiqueb, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/jira refresh |
|
@maiqueb: This pull request references SDN-5346 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
maiqueb
force-pushed
the
virt-tech-preview-lane-on-presubmits
branch
from
e40c67d to
558d61f
Compare
|
/pj-rehearse |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maiqueb
force-pushed
the
virt-tech-preview-lane-on-presubmits
branch
from
558d61f to
e7b6fbd
Compare
|
/pj-rehearse |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maiqueb
force-pushed
the
virt-tech-preview-lane-on-presubmits
branch
from
e7b6fbd to
441d13d
Compare
|
/pj-rehearse |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maiqueb
force-pushed
the
virt-tech-preview-lane-on-presubmits
branch
2 times, most recently
from
7fb09fa to
88fa73f
Compare
There was a problem hiding this comment.
We should probably copy the OWNERS from the hypershift org though ...
@qinqon
maiqueb
force-pushed
the
virt-tech-preview-lane-on-presubmits
branch
from
05fce1c to
262ed8a
Compare
|
/pj-rehearse |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| env: | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DUAL_STACK: "true" | ||
| TEST_ARGS: --run \[sig-network\]\[OCPFeatureGate:PersistentIPsForVirtualization\]\[Feature:Layer2LiveMigration\] | ||
| TEST_SUITE: openshift/conformance |
There was a problem hiding this comment.
let's add a new suite, to avoid having to skip when openshift virt is not deployed (in other lanes).
|
/pj-rehearse |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
This HCO feature gate was introduced in [0]; it also requires the KubeVirt IPAM controller component to persist the IP addresses between VM migrations, and restarts. [0] - kubevirt/hyperconverged-cluster-operator#3034 Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
A future PR will add tests for this feature gate and feature in openshift/origin project. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
…ubmits Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
virt-tech-preview-lane-on-presubmits
branch
from
a4b9268 to
1c2565c
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maiqueb
changed the title
|
/pj-rehearse ack No chance of having the rehearsals working since this suite is not available yet. It's being added in openshift/origin#29186 |
|
@maiqueb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@kyrtapz o/ Could you take another look ? |
|
@maiqueb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
These new jobs will be using the new suite being developed in the origin repo, IIUC. I think it may make sense to add this job as |
| then | ||
| # Add pullsecret for cnv nightly channel from quay.io/openshift-cnv | ||
| QUAY_USERNAME=openshift-cnv+openshift_ci | ||
| QUAY_PASSWORD=$(cat /etc/cnv-nightly-pull-credentials/openshift_cnv_pullsecret) |
There was a problem hiding this comment.
NIT: Since the script is ran with -x this pullsecret gets outputed to stdout. This is currently fine in CI as it takes care of obfuscating it but I think it would be best to avoid outputting it in the first place, can be done as a followup.
|
/lgtm |
|
/pj-rehearse ack |
|
@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/approve |
2 similar comments
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, knobunc, kyrtapz, maiqueb, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
openshift-merge-bot
bot
merged commit f16f634
into
openshift:master
OpenShift virtualization is only supported on:
Hence, let's run CI on AWS nodes. A follow-up PR will add lanes on baremetal.