Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/templates/openshift/installer: Drop unnecessary copy of installer to shared volume #7063

Closed
wants to merge 1 commit into from
Closed

ci-operator/templates/openshift/installer: Drop unnecessary copy of installer to shared volume #7063

wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Feb 7, 2020

I started doing this in 00d7b3f (#2911), but the teardown container doesn't need an installer injected if it running an installer image.

$ git grep -A1 'name: teardown' ci-operator/templates/openshift/installer | grep image:
ci-operator/templates/openshift/installer/cluster-launch-installer-custom-test-image.yaml-      image: ${IMAGE_TESTS}
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml-      image: ${IMAGE_TESTS}
ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml-      image: ${IMAGE_LIBVIRT_INSTALLER}
ci-operator/templates/openshift/installer/cluster-launch-installer-metal-e2e.yaml-      image: ${IMAGE_UPI_INSTALLER}
ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml-      image: ${IMAGE_OPENSTACK_INSTALLER}
ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml-      image: "${IMAGE_LIBVIRT_INSTALLER}"
ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml-      image: ${IMAGE_TESTS}
ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml-      image: ${IMAGE_UPI_INSTALLER}
ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml-      image: ${IMAGE_UPI_INSTALLER}

So this commit removes the openshift-installer copy from the templates that use installer images, and leaves it for templates that use test images.

@wking
ci-operator/templates/openshift/installer: Drop unnecessary copy of i…
169227b 
…nstaller to shared volume

I started doing this in 00d7b3f (ci-operator/templates/openshift:
Use IMAGE_TESTS for teardown gzip, 2019-02-19, openshift#2911), but the
teardown container doesn't need an installer injected if it running an
installer image.

  $ git grep -A1 'name: teardown' ci-operator/templates/openshift/installer | grep image:
  ci-operator/templates/openshift/installer/cluster-launch-installer-custom-test-image.yaml-      image: ${IMAGE_TESTS}
  ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml-      image: ${IMAGE_TESTS}
  ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml-      image: ${IMAGE_LIBVIRT_INSTALLER}
  ci-operator/templates/openshift/installer/cluster-launch-installer-metal-e2e.yaml-      image: ${IMAGE_UPI_INSTALLER}
  ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml-      image: ${IMAGE_OPENSTACK_INSTALLER}
  ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml-      image: "${IMAGE_LIBVIRT_INSTALLER}"
  ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml-      image: ${IMAGE_TESTS}
  ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml-      image: ${IMAGE_UPI_INSTALLER}
  ci-operator/templates/openshift/installer/cluster-launch-installer-upi-src.yaml-      image: ${IMAGE_UPI_INSTALLER}

So this commit removes the openshift-installer copy from the templates
that use installer images, and leaves it for templates that use test
images.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2020
@vrutkovs
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@vrutkovs
Copy link
Member

Github says it needs rebase, but Prow didn't notice that

@openshift-ci-robot
Copy link
Contributor

@wking: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/fcos/e2e-vsphere 169227b link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-openstack 169227b link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-proxy 169227b link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-scaleup-rhel7 169227b link /test pj-rehearse
ci/prow/pj-rehearse 169227b link /test pj-rehearse
ci/prow/app-ci-config 169227b link /test app-ci-config
ci/prow/generated-cluster 169227b link /test generated-cluster
ci/prow/ci-operator-config 169227b link /test ci-operator-config
ci/prow/ci-operator-config-metadata 169227b link /test ci-operator-config-metadata
ci/build-farm/app-ci-config-dry 169227b link /test app-ci-config-dry
ci/build-farm/build02-dry 169227b link /test build02-dry
ci/prow/release-controller-config 169227b link /test release-controller-config
ci/prow/step-registry-metadata 169227b link /test step-registry-metadata
ci/prow/ci-testgrid-allow-list 169227b link /test ci-testgrid-allow-list
ci/prow/yamllint 169227b link /test yamllint
ci/prow/boskos-config 169227b link /test boskos-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/release-config 169227b link /test release-config
ci/prow/boskos-config-generation 169227b link /test boskos-config-generation
ci/prow/secret-generator-config-valid 169227b link /test secret-generator-config-valid
ci/prow/deprecate-templates 169227b link /test deprecate-templates

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2021

@wking: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ci-secret-generator-config 169227b link /test ci-secret-generator-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 14, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jun 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wking @vrutkovs @openshift-ci-robot @openshift-merge-robot @openshift-bot