-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCO: bump golang to 1.13 in 4.5 and above release #8148
Conversation
In 4.5 and above releases, Machine-config-operator is switching to kubernetes 1.18.0 version. This requires switching to Go 1.13 Related - openshift/machine-config-operator#1618 Signed-off-by: Sinny Kumari <sinny@redhat.com>
/cc @runcom |
/retest |
Error log from some of failing tests:
|
Is almost certainly fallout from openshift/machine-config-operator#1619 - CI is finally "self hosting" on 4.X and now PRs to the MCO are failing because we need to improve the MCO - new levels of excitement! |
hmm, thoughts on how to deal with it? |
The change is being reverted in the CI cluster, so it should just be a matter of waiting a bit and |
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@sinnykumari: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@sinnykumari: Updated the following 15 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In 4.5 and above releases, Machine-config-operator is switching to
kubernetes 1.18.0 version. This requires switching to Go 1.13
Related - openshift/machine-config-operator#1618
Signed-off-by: Sinny Kumari sinny@redhat.com