Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO: bump golang to 1.13 in 4.5 and above release #8148

Merged
merged 1 commit into from
Apr 7, 2020
Merged

MCO: bump golang to 1.13 in 4.5 and above release #8148

merged 1 commit into from
Apr 7, 2020

Conversation

sinnykumari
Copy link
Contributor

In 4.5 and above releases, Machine-config-operator is switching to
kubernetes 1.18.0 version. This requires switching to Go 1.13

Related - openshift/machine-config-operator#1618

Signed-off-by: Sinny Kumari sinny@redhat.com

@sinnykumari
MCO: bump golang to 1.13 in 4.5 and above release
b9f8407 
In 4.5 and above releases, Machine-config-operator is switching to
kubernetes 1.18.0 version. This requires switching to Go 1.13

Related - openshift/machine-config-operator#1618

Signed-off-by: Sinny Kumari <sinny@redhat.com>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@sinnykumari sinnykumari mentioned this pull request Apr 6, 2020
Merged
@sinnykumari
Copy link
Contributor Author

/cc @runcom

@sinnykumari
Copy link
Contributor Author

/retest

@sinnykumari
Copy link
Contributor Author

Error log from some of failing tests:

no space left on device"

@cgwalters
Copy link
Member

no space left on device

Is almost certainly fallout from openshift/machine-config-operator#1619 - CI is finally "self hosting" on 4.X and now PRs to the MCO are failing because we need to improve the MCO - new levels of excitement!

@sinnykumari
Copy link
Contributor Author

no space left on device

Is almost certainly fallout from openshift/machine-config-operator#1619 - CI is finally "self hosting" on 4.X and now PRs to the MCO are failing because we need to improve the MCO - new levels of excitement!

hmm, thoughts on how to deal with it?

@cgwalters
Copy link
Member

hmm, thoughts on how to deal with it?

The change is being reverted in the CI cluster, so it should just be a matter of waiting a bit and
/retest

@sinnykumari
Copy link
Contributor Author

/retest

@runcom
Copy link
Member

runcom commented Apr 7, 2020

/retest
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom
Copy link
Member

runcom commented Apr 7, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@sinnykumari: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-disruptive b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-gcp-op b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-gcp-op b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-aws-disruptive b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-vsphere b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-openstack b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-aws-scaleup-rhel7 b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-gcp-upgrade b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-scaleup-rhel7 b9f8407 link /test pj-rehearse
ci/prow/pj-rehearse b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/unit b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/unit b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/unit b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/verify b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/verify b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-openstack b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/verify b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-vsphere b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-gcp-upgrade b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-aws-disruptive b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-gcp-op b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-aws b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-ovirt b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-aws-scaleup-rhel7 b9f8407 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/images b9f8407 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1e76f08 into openshift:master Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: Updated the following 15 configmaps:

  • ci-operator-4.5-configs configmap in namespace ci-stg at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5.yaml
  • ci-operator-4.5-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6.yaml
  • ci-operator-4.6-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6.yaml
  • ci-operator-4.6-configs configmap in namespace ci-stg at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6.yaml

In response to this:

In 4.5 and above releases, Machine-config-operator is switching to
kubernetes 1.18.0 version. This requires switching to Go 1.13

Related - openshift/machine-config-operator#1618

Signed-off-by: Sinny Kumari sinny@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari sinnykumari mentioned this pull request Apr 14, 2020
Closed
@yuqi-zhang yuqi-zhang mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@runcom runcom Awaiting requested review from runcom

Assignees

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
6 participants
@sinnykumari @cgwalters @runcom @openshift-ci-robot @openshift-bot @openshift-merge-robot