-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-8646: bump openshift/library-go to drop mongo-driver references #462
OCPBUGS-8646: bump openshift/library-go to drop mongo-driver references #462
Conversation
1d41efc
to
0b74444
Compare
/test images |
/retest-required |
0b74444
to
ba9201e
Compare
Changed commit message to reference the bug. |
@alebedev87: This pull request references Jira Issue OCPBUGS-8646, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@alebedev87: This pull request references Jira Issue OCPBUGS-8646, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ba9201e
to
a5558ee
Compare
/test images |
/retest-required |
From QE side, checked it with 4.13.0-0.ci.test-2023-03-22-055438-ci-ln-ifgc7qb-latest % oc rsync -n openshift-ingress $(oc get pods -n openshift-ingress --no-headers | grep "^router-default" | grep Running | head -1 | awk '{print $1}'):/usr/bin/openshift-router . % go version -m openshift-router | grep github.com/openshift/client-go /label qe-approved |
/retest-required |
/test e2e-metal-ipi-ovn-ipv6 Mirroring problem, should be fixed by now. |
/test e2e-upgrade |
2 similar comments
/test e2e-upgrade |
/test e2e-upgrade |
@alebedev87: This pull request references Jira Issue OCPBUGS-8646, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the description update. |
Yes, for me that would be appropriate. /lgtm Added hold in case somebody else on the team wants to leave the title as is. |
a5558ee
to
3c578cd
Compare
@alebedev87: This pull request references Jira Issue OCPBUGS-8646, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The latest change is just a commit message update. |
/test e2e-aws-serial |
/retest-required |
I agree that the title doesn't need to mention the CVE.
Looking through the Git history, is it obvious why the change was made? It makes sense to me to explain the reason for the bump in the commit message. |
I think I agree with this. Would a better commit message be |
The referenced version of go.mongodb.org/mongo-driver is affected by CVE-2021-20329. Which may provoke false positives from the vulnerability scanners despite the fact that no files from go.mongodb.org/mongo-driver were actually vendored in this repository.
3c578cd
to
5a06c61
Compare
Updated the commit to give more details on why the PR and why this way. |
/lgtm |
/retest |
1 similar comment
/retest |
Cluster installation failed. /test e2e-aws-serial |
/test e2e-aws-serial |
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alebedev87: Jira Issue OCPBUGS-8646: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-8646 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bump new version of
github.com/openshift/library-go
to more recent version. This helps to get rid of some stale dependencies includingmongo-driver
(notego.sum
removals).