V0.1.29 rebase master #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was using getCmd instead of describeCmd
…ubernetes-retired#2237) * remove from travis integration-tests which are now running in prow * document why we build what we're building
Signed-off-by: Doug Davis <dug@us.ibm.com>
* Add ginkgo tests for svcat get classes * Update generated code * Test the Run method instead of getAll
…rnetes-retired#2190) * Add svcat command to create user-defined cluster-scoped classes * Code improvements following review - Add 'create' command to svcat main.go; - Changes Cobra command declaration; - Improve new test on pkg/svcat/service-catalog/class_test.go - Fix data provided to new generated class on cmd/svcat/class/create_cmd.go - Print success message to the user after creating a class - Add unittest to cmd/svcat/svcat_test.go - Update goldenfiles * Fix help messaging language * Use class data got from RetrieveClassByName to pass to CreateClass in cmd * Fix create class unit test on pkg * Fix pkg tests for CreateClass - Change Name instead of ExternalName * Fix cmd tests for CreateClass - Change Name instead of ExternalName - Add CreateClass to sdk interface * Update golden files * Use WriteClassDetails instead of only printing the name of new class * Add CreateClass to fake_svcat_client.go * Add create_cmd_test.go * Add entry to docs/cli * Add comments to fix lint messages * Fix wrongly removed function from FakeSvcatClient
- sort OWNERS file alphabetically
) * Retrieve brokers by scope * Add Broker interface * Apply Namespaced interface to svcat get broker command * List namespaced brokers with svcat * Add ns-scoped broker testdata * Sync generated files with new broker flags * Sync golden files * Update generated fake * Update unit tests for RetrieveBrokers to validate ns-scoped brokers too * Add unit tests for get brokers command * Document listing namespaced brokers with svcat
…t 80 cols (kubernetes-retired#2226) * Make the last col of get-classes and get-plans wider so we're at least 80 cols Signed-off-by: Doug Davis <dug@us.ibm.com> * make it generic Signed-off-by: Doug Davis <dug@us.ibm.com>
This isn't 100% correct, but it's a pretty good approximation. Specifically, it doesn't know about transitive dependencies from other go packages. But it'll rebuild a generator if any code inside its package changes (or build them all if anything in gengo changes).
…be used appropriately for all types (kubernetes-retired#2214) * Ensure that ObjectMeta field selectors (e.g. name and namespace) can be used appropriately for all types * Add client tests for namespaced resources
Merge executed via ./UPSTREAM-MERGE.sh v0.1.29 upstream master Overwritten conflicts: <NONE>
|
/test service-catalog |
|
/retest |
1 similar comment
|
/retest |
|
CI should be picking up openshift/origin#20673 |
|
/retest |
1 similar comment
|
/retest |
|
/test service-catalog |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jboyd01, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.