Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-1619: variant cross-comparison api #1937

Merged

Conversation

sosiouxme
Copy link
Member

@sosiouxme sosiouxme commented Aug 19, 2024

following on previous preparation, this brings the API and UI support together to provide variant cross-comparison.

  • the Compare button is returned to the UI, and bugs with cross-compare fixed.
  • the API converts CR parameters into comparable queries with different sets of variants for basis and sample.
  • the test_details UI displays what is being compared in a helpful format.

image
image
image

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 19, 2024
Copy link
Contributor

openshift-ci bot commented Aug 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2024

@sosiouxme: This pull request references TRT-1619 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

WIP that successfully converts CR parameters into comparable queries with different sets of variants.

does not touch test_details yet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sosiouxme sosiouxme force-pushed the 20240814-variant-comparison-api branch from c91246d to 84271b7 Compare August 19, 2024 17:28
@sosiouxme sosiouxme force-pushed the 20240814-variant-comparison-api branch from 32c48dd to 772cba1 Compare August 21, 2024 00:53
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 21, 2024

@sosiouxme: This pull request references TRT-1619 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

WIP that successfully converts CR parameters into comparable queries with different sets of variants.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sosiouxme sosiouxme force-pushed the 20240814-variant-comparison-api branch from 772cba1 to 9071e28 Compare August 21, 2024 19:05
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 21, 2024

@sosiouxme: This pull request references TRT-1619 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

following on previous preparation, this brings the API and UI support together to provide variant cross-comparison.

  • the Compare button is returned to the UI, and bugs with cross-compare fixed.
  • the API converts CR parameters into comparable queries with different sets of variants for basis and sample.
  • the test_details UI displays what is being compared in a helpful format.

image
image
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sosiouxme sosiouxme force-pushed the 20240814-variant-comparison-api branch 2 times, most recently from d5de034 to 5732d83 Compare August 27, 2024 23:24
@sosiouxme sosiouxme marked this pull request as ready for review August 27, 2024 23:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

@sosiouxme: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 05da6b9 into openshift:master Aug 28, 2024
6 checks passed
@sosiouxme sosiouxme deleted the 20240814-variant-comparison-api branch August 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants