-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(*): Update transient dependency go-ansiterm #1022
Conversation
In a previous PR, Docker has been updated but this specific dependency errored when cross compiling to Windows. The specific version was obtained from moby/moby@dbe4a30#diff-4061fcef378a6d912e14e2ce162a1995L2.
Hi @isutton. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Works for me, thanks!
Should add it to our CI in future. |
/lgtm CC @adambkaplan |
:shakes fist at moby for not using go.mod: Thanks @isutton for catching this! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, isutton, sbose78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following error happens when executing
hack/build-cross.sh
:This happens because a previous PR, Docker has been updated but produced an error when cross compiling to Windows; to mitigate that, the
go-ansiterm
version has been bumped to the specific version obtained from moby/moby@dbe4a30#diff-4061fcef378a6d912e14e2ce162a1995L2.