Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(*): Update transient dependency go-ansiterm #1022

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

isutton
Copy link

@isutton isutton commented Feb 5, 2020

The following error happens when executing hack/build-cross.sh:

./build-cross.sh
++ Building go targets for linux/amd64: cmd/s2i
++ Building go targets for darwin/amd64: cmd/s2i
++ Building go targets for windows/amd64: cmd/s2i
# github.com/docker/docker/pkg/term
../vendor/github.com/docker/docker/pkg/term/term_windows.go:35:44: undefined: winterm.ENABLE_VIRTUAL_TERMINAL_INPUT
../vendor/github.com/docker/docker/pkg/term/term_windows.go:48:44: undefined: winterm.ENABLE_VIRTUAL_TERMINAL_PROCESSING
../vendor/github.com/docker/docker/pkg/term/term_windows.go:48:87: undefined: winterm.DISABLE_NEWLINE_AUTO_RETURN
../vendor/github.com/docker/docker/pkg/term/term_windows.go:51:36: undefined: winterm.ENABLE_VIRTUAL_TERMINAL_PROCESSING
../vendor/github.com/docker/docker/pkg/term/term_windows.go:58:44: undefined: winterm.ENABLE_VIRTUAL_TERMINAL_PROCESSING
../vendor/github.com/docker/docker/pkg/term/term_windows.go:58:87: undefined: winterm.DISABLE_NEWLINE_AUTO_RETURN
../vendor/github.com/docker/docker/pkg/term/term_windows.go:61:36: undefined: winterm.ENABLE_VIRTUAL_TERMINAL_PROCESSING
../vendor/github.com/docker/docker/pkg/term/term_windows.go:172:40: undefined: winterm.DISABLE_NEWLINE_AUTO_RETURN
../vendor/github.com/docker/docker/pkg/term/term_windows.go:202:11: undefined: winterm.ENABLE_VIRTUAL_TERMINAL_INPUT

This happens because a previous PR, Docker has been updated but produced an error when cross compiling to Windows; to mitigate that, the go-ansiterm version has been bumped to the specific version obtained from moby/moby@dbe4a30#diff-4061fcef378a6d912e14e2ce162a1995L2.

In a previous PR, Docker has been updated but this specific dependency
errored when cross compiling to Windows. The specific version was obtained
from moby/moby@dbe4a30#diff-4061fcef378a6d912e14e2ce162a1995L2.
@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2020
@openshift-ci-robot
Copy link

Hi @isutton. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbose78
Copy link

sbose78 commented Feb 5, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2020
@sbose78
Copy link

sbose78 commented Feb 5, 2020

Works for me, thanks!

sbose-mac:source-to-image sbose$ ./hack/build-cross.sh 
++ Building go targets for linux/amd64: cmd/s2i
++ Building go targets for darwin/amd64: cmd/s2i
++ Building go targets for windows/amd64: cmd/s2i
++ Building go targets for linux/386: cmd/s2i
++ Placing binaries
++ Creating source-to-image-v1.2.0-38-gb178763a-b178763a-linux-amd64.tar.gz
++ Creating source-to-image-v1.2.0-38-gb178763a-b178763a-darwin-amd64.tar.gz
++ Creating source-to-image-v1.2.0-38-gb178763a-b178763a-windows-amd64.zip
++ Creating source-to-image-v1.2.0-38-gb178763a-b178763a-linux-386.tar.gz
./hack/build-cross.sh took 38 seconds

Should add it to our CI in future.

@sbose78
Copy link

sbose78 commented Feb 5, 2020

/lgtm
/approve

CC @adambkaplan

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2020
@adambkaplan
Copy link
Contributor

:shakes fist at moby for not using go.mod:

Thanks @isutton for catching this!

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, isutton, sbose78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit ecf5524 into openshift:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants