Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use volume mount in release build #1055

Merged

Conversation

adambkaplan
Copy link
Contributor

  • Use bind mount instead of tar stream to add source code to the release
    container.
  • Update release Dockerfile to declare volume for the s2i source.
    Command updated to remove tar stream in
  • Add sti-version-defs file to .gitignore

- Use bind mount instead of tar stream to add source code to the release
  container.
- Update release Dockerfile to declare volume for the s2i source.
  Command updated to remove tar stream in
- Add sti-version-defs file to .gitignore
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@adambkaplan
Copy link
Contributor Author

/assign @gabemontero

Seems that every time I try to release, I find something wrong with the s2i release script.
This go around, it seems that podman with cgroups v2 doesn't like the tar stream in. This seemed like a silly aspect of the release script anyway, since nowadays it's much easier to bind mount the source code into the container. Bind mounting also saves us the extra podman cp call - the resulting client binaries sit in the _output directory at the end of the build.

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a5a7714 into openshift:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants