Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add seed to container name #956

Merged
merged 1 commit into from
Mar 14, 2019
Merged

add seed to container name #956

merged 1 commit into from
Mar 14, 2019

Conversation

magicsong
Copy link
Contributor

fix #955

@openshift-ci-robot
Copy link

Hi @magicsong. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2019
@bparees
Copy link
Contributor

bparees commented Mar 14, 2019

/assign @adambkaplan
(lgtm though)

@adambkaplan
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2019
adambkaplan
adambkaplan approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2019
@adambkaplan
Copy link
Contributor

[merge]

@adambkaplan
Copy link
Contributor

/approve

@adambkaplan adambkaplan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@adambkaplan
Copy link
Contributor

[test]

@openshift-bot
Copy link
Contributor

Evaluated for source to image test up to a999b00

@openshift-bot
Copy link
Contributor

Source To Image Action Required: Please contact #openshift-dev to have this pull request manually reviewed and tested

@openshift-bot
Copy link
Contributor

Source To Image Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_s2i/806/) (Base Commit: 1b34d86) (PR Branch Commit: a999b00)

@adambkaplan
Copy link
Contributor

[merge]

@adambkaplan adambkaplan merged commit 2ba8a34 into openshift:master Mar 14, 2019
@adambkaplan
Copy link
Contributor

force-merged

@magicsong magicsong deleted the seed branch March 15, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The container name is not rand.
5 participants
@magicsong @openshift-ci-robot @bparees @adambkaplan @openshift-bot