Fix custom restic-restore-helper image not being used #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmontleon
force-pushed
the
fix-restic-helper-configmap-ns
branch
from
b24ac7a
to
6e18531
Compare
dymurray
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sseago @dymurray can you help me get this merged to the correct branch for 1.0.1?
There are two issues. Because we went downt he route of installing velero in a custom namespaces the DefaultNamespace being used to lookup configuration is wrong and velero never finds the configmap.
The second issue is that when found we get an error message that the image is unparseable because the original code does not account for a registry with the port specified.
This was reported and fixed in velero and I have the same fix here, which resolves the problem, even though it is not particularly suited to using SHAs:
vmware-tanzu#1972
vmware-tanzu#1999