[WIP] Reorganization of authentication and security API. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main point is usage of CredentialExtractor API and delegation of all security related operations to AuthenticationManager and multiple implementations of AuthenticationProvider. Relates to #16 Signed-off-by: Łukasz Dywicki <luke@code-house.org>
Indirectly related to #16.
Moved out password credentials out of core package (they are not mandatory kind of creds any more). Added session cookie authentication. Signed-off-by: Łukasz Dywicki <luke@code-house.org>
X-Forwarded-Proto can be a list ie. https, http when two proxy servers are used. This patch makes sure that generated response uses first host/values.
Currently twisting it into interface causes runtime incompatibility within OH.
Make sure that UI components can be provided through other suppliers than system storage.
Signed-off-by: Łukasz Dywicki <luke@code-house.org>
splatch
force-pushed
the
security-cleanup
branch
from
9e512c5
to
9e39f63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point is usage of CredentialExtractor API and delegation of all security related operations to AuthenticationManager and multiple implementations of AuthenticationProvider.
Relates to #16
Signed-off-by: Łukasz Dywicki luke@code-house.org