-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use dagster retry
mechanism
#2184
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approved! please merge responsibly 😄
Test deployment unnecessary, no dbt files have been changed. |
|
@Jabolol I don't think this is an issue because we have concurrency limits but this doesn't currently handle issues with concurrent connections to open collective. I think that should be fine for now, but I am stating it as a sanity check because if multiple clients hit a 429 nearly simultaneously and the rate limits are by API key, I'm not sure if their api has issues with all of those clients retrying again at approximately the same time. |
This PR updates failed queries to use Dagster's retry mechanism instead of failing silently, adjusts the data fetching to reduce nodes to 500 per query—since the Open Collective API returns 503 errors for larger queries—which seems sensible based on local testing and will require further triage, and changes the write disposition to "merge" to prevent duplicates in the dataset.