Skip to content

Commit

Permalink
zebra: evpn-mh: add error logs on ES processing failures
Browse files Browse the repository at this point in the history
Cleanup some of the XXX added during development of MH.

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
  • Loading branch information
AnuradhaKaruppiah committed Sep 23, 2020
1 parent aa178ef commit 4d8b658
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions zebra/zebra_evpn_mh.c
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,6 @@ static int zebra_evpn_es_send_del_to_client(struct zebra_evpn_es *es)
return zserv_send_message(client, s);
}

/* XXX - call any time ZEBRA_EVPNES_LOCAL gets set or cleared */
static void zebra_evpn_es_re_eval_send_to_client(struct zebra_evpn_es *es,
bool es_evi_re_reval)
{
Expand Down Expand Up @@ -1497,7 +1496,9 @@ static int zebra_evpn_remote_es_del(esi_t *esi, struct in_addr vtep_ip)

es = zebra_evpn_es_find(esi);
if (!es) {
/* XXX - error log */
zlog_warn("remote es %s vtep %pI4 del failed, es missing",
esi_to_str(esi, buf, sizeof(buf)),
&vtep_ip);
return -1;
}

Expand Down Expand Up @@ -1538,7 +1539,9 @@ static int zebra_evpn_remote_es_add(esi_t *esi, struct in_addr vtep_ip)
if (!es) {
es = zebra_evpn_es_new(esi);
if (!es) {
/* XXX - error log */
zlog_warn("remote es %s vtep %pI4 add failed, es missing",
esi_to_str(esi, buf, sizeof(buf)),
&vtep_ip);
return -1;
}
}
Expand Down

0 comments on commit 4d8b658

Please sign in to comment.