Skip to content

Commit

Permalink
Stop all logging during add-on termination (fixes unreported bug duri…
Browse files Browse the repository at this point in the history
…ng plugin reloads).
  • Loading branch information
Luke Davis authored and Luke Davis committed Aug 31, 2023
1 parent 149faa0 commit 67080ff
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions addon/globalPlugins/speechLogger/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ def speechLogger_speakWithoutPauses( # noqa: C901
SpeechWithoutPauses.speakWithoutPauses = speechLogger_speakWithoutPauses

def terminate(self) -> None:
# Stop all logging that may be in progress
self.stopRemoteLog()
self.stopLocalLog()
# Remove the NVDA settings panel
if not globalVars.appArgs.secure:
gui.settingsDialogs.NVDASettingsDialog.categoryClasses.remove(SpeechLoggerSettings)
Expand Down

0 comments on commit 67080ff

Please sign in to comment.