Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNC IndexVector #2

Merged
merged 10 commits into from
Jul 27, 2022
Merged

Conversation

varunagrawal
Copy link

@varunagrawal varunagrawal commented Jul 26, 2022

Replace vector<size_t> with a new typedef IndexVector.

The issue with wrapping is that there is a collision happening between vector<size_t> and KeyVector. I updated GNC so that this is taken care of.

@amadoantonini your PR should pass the CI after this.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@amadoantonini amadoantonini merged commit aeceb45 into openspacelabs:main Jul 27, 2022
@varunagrawal varunagrawal deleted the gnc/index-vector branch August 22, 2022 12:55
RachitB11 pushed a commit that referenced this pull request Sep 11, 2023
…olution

a better solution for ISUEE-1433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants