-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable eTagging when performing a POST #2481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary because of this bug |
ndegwamartin
previously approved these changes
Jun 22, 2023
Co-authored-by: Martin Ndegwa <mndegwa@ona.io>
pld
approved these changes
Jun 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #2481 +/- ##
=========================================
+ Coverage 64.8% 65.3% +0.4%
- Complexity 1050 1080 +30
=========================================
Files 209 210 +1
Lines 9156 9250 +94
Branches 1805 1835 +30
=========================================
+ Hits 5942 6047 +105
+ Misses 2059 2027 -32
- Partials 1155 1176 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Oct 13, 2023
Disable using eTAGs - Fixes HTTP 400 exception during transaction bundle sync *Resources:* - hapifhir/hapi-fhir#3575 - opensrp/fhircore#2481
qiarie
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Add the Service Card color test * 🐛 Disable eTagging on uploading the bundle * 🎨 Remove duplicate test * 📝 Add documentation Co-authored-by: Martin Ndegwa <mndegwa@ona.io> * ♻️ Run spotless * ✅ Asserting to check that etagToUpload is false --------- Co-authored-by: Martin Ndegwa <mndegwa@ona.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes bug when doing POST for a bundle containing an entry that is a /Binary
PATCH
request. If this request has anifCondition
it fails on the HAPI FHIR Server and you get the following400
errorHAPI-0518: Invalid match URL[Group?W/\"1\"] - URL has no search parameters
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file