Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable eTagging when performing a POST #2481

Merged
merged 10 commits into from
Jun 22, 2023

Conversation

dubdabasoduba
Copy link
Member

@dubdabasoduba dubdabasoduba commented Jun 22, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes bug when doing POST for a bundle containing an entry that is a /Binary PATCH request. If this request has an ifCondition it fails on the HAPI FHIR Server and you get the following 400 error

HAPI-0518: Invalid match URL[Group?W/\"1\"] - URL has no search parameters

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@dubdabasoduba
Copy link
Member Author

Necessary because of this bug

ndegwamartin
ndegwamartin previously approved these changes Jun 22, 2023
Co-authored-by: Martin Ndegwa <mndegwa@ona.io>
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #2481 (5adc25e) into main (2ea8fa1) will increase coverage by 0.4%.
The diff coverage is 64.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2481     +/-   ##
=========================================
+ Coverage     64.8%   65.3%   +0.4%     
- Complexity    1050    1080     +30     
=========================================
  Files          209     210      +1     
  Lines         9156    9250     +94     
  Branches      1805    1835     +30     
=========================================
+ Hits          5942    6047    +105     
+ Misses        2059    2027     -32     
- Partials      1155    1176     +21     
Flag Coverage Δ
engine 73.0% <59.5%> (-0.1%) ⬇️
geowidget 63.2% <ø> (ø)
quest 60.3% <67.1%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ine/configuration/view/ViewPropertiesSerializer.kt 25.0% <0.0%> (-1.4%) ⬇️
...e/engine/ui/bottomsheet/RegisterBottomSheetView.kt 51.2% <0.0%> (-2.5%) ⬇️
...hircore/quest/ui/shared/components/CompoundText.kt 75.2% <0.0%> (-0.9%) ⬇️
...fhircore/quest/util/extensions/ConfigExtensions.kt 67.1% <0.0%> (-2.9%) ⬇️
...egister/fhircore/quest/ui/main/AppMainViewModel.kt 73.2% <33.3%> (-1.3%) ⬇️
...rcore/engine/configuration/view/ImageProperties.kt 34.6% <34.6%> (ø)
...core/engine/configuration/view/ButtonProperties.kt 52.2% <50.0%> (ø)
...gine/ui/bottomsheet/RegisterBottomSheetFragment.kt 37.5% <50.0%> (+1.7%) ⬆️
...ter/fhircore/quest/ui/main/components/AppDrawer.kt 68.2% <50.0%> (-0.5%) ⬇️
...ter/fhircore/quest/ui/register/RegisterFragment.kt 42.6% <50.0%> (+13.2%) ⬆️
... and 17 more

... and 3 files with indirect coverage changes

@dubdabasoduba dubdabasoduba merged commit 0d54e74 into main Jun 22, 2023
@dubdabasoduba dubdabasoduba deleted the feature/disable_etag_for_upload branch June 22, 2023 18:43
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Oct 13, 2023
Disable using eTAGs - Fixes HTTP 400 exception during transaction bundle sync

*Resources:*
- hapifhir/hapi-fhir#3575
- opensrp/fhircore#2481
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Add the Service Card color test

* 🐛 Disable eTagging on uploading the bundle

* 🎨 Remove duplicate test

* 📝 Add documentation

Co-authored-by: Martin Ndegwa <mndegwa@ona.io>

* ♻️ Run spotless

* ✅ Asserting to check that etagToUpload is false

---------

Co-authored-by: Martin Ndegwa <mndegwa@ona.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants