Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to SDK workflow evaluator from local Library eval #2833

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Conversation

maimoonak
Copy link
Contributor

@maimoonak maimoonak commented Oct 23, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2833 (9403c1e) into main (ad3a737) will increase coverage by 2.4%.
Report is 91 commits behind head on main.
The diff coverage is 63.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2833     +/-   ##
=========================================
+ Coverage     64.5%   66.9%   +2.4%     
- Complexity    1075    1090     +15     
=========================================
  Files          218     221      +3     
  Lines         9635   10079    +444     
  Branches      1897    1874     -23     
=========================================
+ Hits          6218    6751    +533     
+ Misses        2234    2143     -91     
- Partials      1183    1185      +2     
Flag Coverage Δ
engine 70.4% <67.7%> (-2.3%) ⬇️
geowidget 65.5% <33.3%> (+1.1%) ⬆️
quest 64.6% <60.1%> (+5.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ngine/configuration/view/CompoundTextProperties.kt 100.0% <ø> (ø)
...r/fhircore/engine/domain/model/RoundingStrategy.kt 100.0% <100.0%> (ø)
...gister/fhircore/engine/rulesengine/RulesFactory.kt 71.8% <100.0%> (+0.6%) ⬆️
...martregister/fhircore/engine/sync/AppSyncWorker.kt 100.0% <ø> (ø)
...ister/fhircore/engine/task/FhirTaskExpireWorker.kt 100.0% <100.0%> (ø)
...fhircore/engine/task/FhirTaskStatusUpdateWorker.kt 100.0% <100.0%> (ø)
...g/smartregister/fhircore/engine/ui/theme/Colors.kt 100.0% <100.0%> (ø)
...rcore/engine/util/extension/FhirEngineExtension.kt 80.0% <100.0%> (+2.8%) ⬆️
...r/fhircore/geowidget/screens/GeoWidgetViewModel.kt 86.6% <100.0%> (+0.3%) ⬆️
...smartregister/fhircore/quest/QuestConfigService.kt 97.6% <ø> (-0.1%) ⬇️
... and 70 more

... and 32 files with indirect coverage changes

@ellykits
Copy link
Collaborator

@maimoonak This is good. Can you update the library versions to the ones declared here? Use the Google versions to override our published versions.google/android-fhir#2187

@maimoonak maimoonak marked this pull request as ready for review October 24, 2023 08:04
@ellykits ellykits merged commit bc4185f into main Oct 24, 2023
@ellykits ellykits deleted the to-workflow-eval branch October 24, 2023 09:59
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Move to SDK workflow evaluator from local Library eval

* Fix tests

* spotless apply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants