Caching questionnaires and their SM

[aurangzaibumer]

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

• I have written Unit tests for any new feature(s) and edge cases for bug fixes
• I have added any strings visible on UI components to the strings.xml file
• I have updated the CHANGELOG.md file for any notable changes to the codebase
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
• I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
• I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

• I have verified Unit tests have been written for any new feature(s) and edge cases
• I have verified any strings visible on UI components are in the strings.xml file
• I have verifed the CHANGELOG.md file has any notable changes to the codebase
• I have verified the solution has been implemented in a configurable and generic way for reuseable components
• I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.3%. Comparing base (6fc15b0) to head (c173f82).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...er/fhircore/engine/data/local/DefaultRepository.kt	25.0%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##              main   #3461     +/-   ##
=========================================
+ Coverage     27.1%   27.3%   +0.2%     
- Complexity     775     782      +7     
=========================================
  Files          279     281      +2     
  Lines        14563   14551     -12     
  Branches      2608    2602      -6     
=========================================
+ Hits          3957    3985     +28     
+ Misses       10065   10023     -42     
- Partials       541     543      +2     

Flag	Coverage Δ
engine	63.8% <72.7%> (+<0.1%)	⬆️
geowidget	16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...egister/fhircore/engine/data/local/ContentCache.kt	100.0% <100.0%> (ø)
...ster/fhircore/engine/task/FhirCarePlanGenerator.kt	78.2% <100.0%> (+0.1%)	⬆️
...tregister/fhircore/quest/ui/login/LoginActivity.kt	5.8% <ø> (ø)
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt	3.3% <ø> (+<0.1%)	⬆️
...er/fhircore/engine/data/local/DefaultRepository.kt	58.6% <25.0%> (-0.4%)	⬇️

[ndegwamartin]

@aurangzaibumer could we add a unit test for the ViewModel itself? You can mock anything you don't need/already tested in the Cache test if need be.

[ndegwamartin]

Lets add a verify assertion here to verify that the
defaultRepository.loadResource<Questionnaire>(questionnaireConfig.id) method was not called (i.e. was called zero times)

[ndegwamartin]

And we can probably split this to 2 unit tests to get better coverage for the changes in this class.

• Test case 1 to test for when the questionnaire is Found in the cache
• Test case 2 to test for when the questionnaire is Not Found in the cache

So basically use the:

val questionnaire =
      questionnaireViewModel.retrieveQuestionnaire(
        questionnaireConfig = questionnaireConfig,
      ) 

method as the focus of the test case and leave out the ContentCache.save invocations since those are already tested in the ContentCacheTest class

[ndegwamartin]

We can add some test cases for the Structure Map caching as well

[ellykits]

What's the strategy used when this cache is full?

[ndegwamartin]

Least recently used