Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIR Core Enhancements #3587

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

FHIR Core Enhancements #3587

wants to merge 11 commits into from

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.0%. Comparing base (6fc15b0) to head (28b836a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3587     +/-   ##
=========================================
- Coverage     27.1%   27.0%   -0.2%     
+ Complexity     775     771      -4     
=========================================
  Files          279     279             
  Lines        14563   14502     -61     
  Branches      2608    2598     -10     
=========================================
- Hits          3957    3919     -38     
+ Misses       10065   10049     -16     
+ Partials       541     534      -7     
Flag Coverage Δ
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...core/engine/configuration/ConfigurationRegistry.kt 69.7% <ø> (+1.2%) ⬆️
.../fhircore/engine/p2p/dao/P2PReceiverTransferDao.kt 88.2% <ø> (-1.3%) ⬇️
...er/fhircore/engine/p2p/dao/P2PSenderTransferDao.kt 75.0% <ø> (+2.5%) ⬆️
...martregister/fhircore/engine/sync/AppSyncWorker.kt 100.0% <ø> (+8.3%) ⬆️
...smartregister/fhircore/engine/util/ParallelUtil.kt 66.6% <ø> (-8.4%) ⬇️
...hircore/engine/util/extension/ResourceExtension.kt 66.7% <ø> (-0.9%) ⬇️
...fhircore/quest/ui/appsetting/AppSettingActivity.kt 0.0% <ø> (ø)
...hircore/quest/ui/appsetting/AppSettingViewModel.kt 2.2% <ø> (+<0.1%) ⬆️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 3.2% <ø> (+<0.1%) ⬆️

@dubdabasoduba
Copy link
Member

Tests run on Samsung A25 (128+6GB)
Release App(Madagascar)

  • Login(follow up) - 0:00:26.23
  • Load SP Register(298SPs - Filter, clear app from memory, then login afresh) - 0:02:31.16
  • Search a SP - 0:05:32.22
  • Load a Service Point profile - 0:00:01.38
  • Loading a SP check form - 0:00:00.99
  • Submit a SP check form(save) - 0:00:01.50
  • Loading a Consult beneficiaries form - 0:00:01.08
  • Submit a Consult beneficiaries form(save) - 0:00:01.48
  • Loading a Update GPS form - 0:00:00.98
  • Submit a Update GPS form(save) - 0:00:00.93
  • Loading Past Visit page - 0:00:00.9

Performance app

  • Login(follow up) - 0:00:12.15
  • Load SP Register(290SPs - Filter, clear app from memory, then login afresh) - 0:02:02.90
  • Search a SP - 0:00:27.85(first result) - 0:03:10.55(complete search)
  • Load a Service Point profile - 0:00:01.35
  • Loading a SP check form - 0:00:01.46
  • Submit a SP check form(save) - 0:00:01.31
  • Loading a Consult beneficiaries form - 0:00:01.80
  • Submit a Consult beneficiaries form(save) - 0:00:01.43
  • Loading a Update GPS form - 0:00:01.56
  • Submit a Update GPS form(save) - 0:00:01.56
  • Loading Past Visit page - 0:00:01.04

@dubdabasoduba
Copy link
Member

@Mstjamush Thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants