Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genai speech to form #3666

Open
wants to merge 77 commits into
base: main
Choose a base branch
from
Open

Genai speech to form #3666

wants to merge 77 commits into from

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Dec 19, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/onaio/fhir-resources/issues/3676

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 25.04039% with 464 lines in your changes missing coverage. Please review.

Project coverage is 37.3%. Comparing base (a790c9d) to head (8248eec).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 0.0% 151 Missing ⚠️
...ore/quest/ui/questionnaire/SpeechToTextFragment.kt 0.0% 125 Missing ⚠️
...t/medintel/speech/speechtoform/LiveSpeechToText.kt 0.0% 55 Missing ⚠️
...re/quest/ui/questionnaire/SpeechToTextViewModel.kt 0.0% 48 Missing ⚠️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 33.3% 28 Missing ⚠️
...e/quest/medintel/speech/speechtoform/TextToForm.kt 68.4% 19 Missing and 5 partials ⚠️
...quest/medintel/speech/speechtoform/SpeechToForm.kt 0.0% 14 Missing ⚠️
...hircore/quest/medintel/speech/models/GemmaModel.kt 20.0% 12 Missing ⚠️
...quest/medintel/speech/speechtoform/SpeechToText.kt 79.3% 4 Missing and 2 partials ⚠️
.../fhircore/quest/util/QuestionnaireResponseUtils.kt 96.8% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (25.0%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3666     +/-   ##
=========================================
- Coverage     38.6%   37.3%   -1.3%     
- Complexity    1168    1184     +16     
=========================================
  Files          286     297     +11     
  Lines        15291   16002    +711     
  Branches      2697    2790     +93     
=========================================
+ Hits          5907    5982     +75     
- Misses        8536    9183    +647     
+ Partials       848     837     -11     
Flag Coverage Δ
engine 60.7% <100.0%> (-2.1%) ⬇️
geowidget 16.0% <ø> (ø)
quest 24.4% <24.9%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ircore/engine/configuration/QuestionnaireConfig.kt 79.2% <100.0%> (-0.8%) ⬇️
...ircore/quest/medintel/speech/models/GeminiModel.kt 100.0% <100.0%> (ø)
...fhircore/quest/medintel/summarization/Summarize.kt 100.0% <100.0%> (ø)
.../fhircore/quest/util/QuestionnaireResponseUtils.kt 96.8% <96.8%> (ø)
...quest/medintel/speech/speechtoform/SpeechToText.kt 79.3% <79.3%> (ø)
...hircore/quest/medintel/speech/models/GemmaModel.kt 20.0% <20.0%> (ø)
...quest/medintel/speech/speechtoform/SpeechToForm.kt 0.0% <0.0%> (ø)
...e/quest/medintel/speech/speechtoform/TextToForm.kt 68.4% <68.4%> (ø)
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 63.1% <33.3%> (-3.1%) ⬇️
...re/quest/ui/questionnaire/SpeechToTextViewModel.kt 0.0% <0.0%> (ø)
... and 3 more

... and 8 files with indirect coverage changes

@pld pld force-pushed the genai-speech-to-form branch 2 times, most recently from c5f62a5 to fd190ca Compare December 22, 2024 13:52
@pld pld force-pushed the genai-speech-to-form branch from fd190ca to 320f599 Compare December 28, 2024 01:27
@pld pld force-pushed the genai-speech-to-form branch from d71efc8 to 982399f Compare January 9, 2025 04:20
pld and others added 27 commits January 22, 2025 09:36
Since full version protobuf-java is required for com.google.cloud:google-cloud-speech
@LZRS LZRS marked this pull request as ready for review February 6, 2025 11:58
@LZRS LZRS requested a review from ellykits February 6, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants