Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies ⬆️ #3711

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Upgrade dependencies ⬆️ #3711

merged 2 commits into from
Feb 5, 2025

Conversation

ndegwamartin
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

In this PR:

  • Upgrade FHIR SDK Engine + SDC dependencies
  • Upgrade Android and Other dependencies

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

- Upgrade FHIR SDK Engine + SDC dependencies
- Upgrade Android and Other dependencies
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 37.8%. Comparing base (a790c9d) to head (7e1f1ca).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...report/measure/screens/ReportTypeSelectorScreen.kt 0.0% 2 Missing ⚠️
.../report/measure/screens/MeasureReportListScreen.kt 0.0% 1 Missing ⚠️
...eport/measure/screens/MeasureReportResultScreen.kt 0.0% 1 Missing ⚠️
...e/quest/ui/usersetting/UserSettingInsightScreen.kt 0.0% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.0%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3711     +/-   ##
=========================================
- Coverage     38.6%   37.8%   -0.8%     
+ Complexity    1168    1150     -18     
=========================================
  Files          286     287      +1     
  Lines        15291   15471    +180     
  Branches      2697    2721     +24     
=========================================
- Hits          5907    5858     -49     
- Misses        8536    8775    +239     
+ Partials       848     838     -10     
Flag Coverage Δ
engine 60.7% <ø> (-2.1%) ⬇️
geowidget 16.0% <ø> (ø)
quest 24.4% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../report/measure/screens/MeasureReportListScreen.kt 0.0% <0.0%> (ø)
...eport/measure/screens/MeasureReportResultScreen.kt 0.0% <0.0%> (ø)
...e/quest/ui/usersetting/UserSettingInsightScreen.kt 0.0% <0.0%> (ø)
...report/measure/screens/ReportTypeSelectorScreen.kt 0.0% <0.0%> (ø)

... and 8 files with indirect coverage changes

@ndegwamartin ndegwamartin merged commit 8133797 into main Feb 5, 2025
4 of 5 checks passed
@ndegwamartin ndegwamartin deleted the upgrade-dependencies branch February 5, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants