Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Handle Missing baseEntityId in Event JSON for Save for v2 #591

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Bug Fix: Handle Missing baseEntityId in Event JSON for Save for v2 #591

merged 4 commits into from
Jul 13, 2022

Conversation

qiarie
Copy link
Contributor

@qiarie qiarie commented Jul 12, 2022

Resolves issue #589

  • Handle Empty Event or Missing baseEntityId During Event Save
  • Handle Missing Details Field in Event When Processing outOfArea Event

@qiarie qiarie changed the base branch from master to v2 July 12, 2022 19:40
hilpitome
hilpitome approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@hilpitome hilpitome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@qiarie qiarie merged commit 73c0d00 into v2 Jul 13, 2022
@qiarie qiarie deleted the 589-fix-missing-baseentityid-in-event-json-v2 branch July 13, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rkareko Rkareko Rkareko approved these changes

@hilpitome hilpitome hilpitome approved these changes

@ekigamba ekigamba Awaiting requested review from ekigamba

@ndegwamartin ndegwamartin Awaiting requested review from ndegwamartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiarie @hilpitome @Rkareko