Drop MPL licensed dependency dirs-sys #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Can you also update src/changelog.rs please? |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
|
NobodyXu
requested changes
Jan 21, 2024
|
Can you rebase against main please (not merge from main though)? |
|
I can do it for u from GH ui if you are ok with it |
Get state dir from env variables instead
Too late, I already did :) |
|
Will cut a release later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot updated
dirscrate to version 5.0.0 here: #114. Between versions 4.0 and 5.0 dirs crate included a small dependency with MPL license, there's several tickets to dirs crate about this issue closed as WONTFIX, you can find some relevant links here: harryfei/which-rs#78One possible solution is to pin
dirsto some older version, but functionality used byopensshis simple enough to implement from scratch