Skip to content

Commit

Permalink
Remove --classic build entirely
Browse files Browse the repository at this point in the history
The Unix build was the last to retain the classic build scheme.  The
new unified scheme has matured enough, even though some details may
need polishing.

Reviewed-by: Rich Salz <rsalz@openssl.org>
  • Loading branch information
levitte committed Apr 20, 2016
1 parent f863ad0 commit 45c6e23
Show file tree
Hide file tree
Showing 67 changed files with 8 additions and 4,921 deletions.
24 changes: 6 additions & 18 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ env:
- CONFIG_OPTS=""
- CONFIG_OPTS="--debug no-shared enable-crypto-mdebug enable-rc5 enable-md2"
- CONFIG_OPTS="--strict-warnings no-shared" BUILDONLY="yes"
- CONFIG_OPTS="--classic no-shared" BUILDONLY="yes"
- CONFIG_OPTS="--classic" BUILDONLY="yes"
- CONFIG_OPTS="no-pic --strict-warnings" BUILDONLY="yes"
- CONFIG_OPTS="no-engine no-shared --strict-warnings" BUILDONLY="yes"

Expand Down Expand Up @@ -60,34 +58,24 @@ matrix:
before_script:
- sh .travis-create-release.sh $TRAVIS_OS_NAME
- tar -xvzf _srcdist.tar.gz
- if echo "$CONFIG_OPTS" | grep -e "--classic" >/dev/null; then
srcdir=.;
cd _srcdist;
else
srcdir=../_srcdist;
mkdir _build;
cd _build;
fi
- mkdir _build;
- cd _build;
- if [ "$CC" == i686-w64-mingw32-gcc ]; then
export CROSS_COMPILE=${CC%%gcc}; unset CC;
$srcdir/Configure mingw $CONFIG_OPTS -Wno-pedantic-ms-format;
../_srcdir/Configure mingw $CONFIG_OPTS -Wno-pedantic-ms-format;
elif [ "$CC" == x86_64-w64-mingw32-gcc ]; then
export CROSS_COMPILE=${CC%%gcc}; unset CC;
$srcdir/Configure mingw64 $CONFIG_OPTS -Wno-pedantic-ms-format;
../_srcdir/Configure mingw64 $CONFIG_OPTS -Wno-pedantic-ms-format;
else
if which ccache >/dev/null && [ "$CC" != clang-3.6 ]; then
CC="ccache $CC";
fi;
$srcdir/config $CONFIG_OPTS;
../_srcdir/config $CONFIG_OPTS;
fi
- cd ..

script:
- if echo "$CONFIG_OPTS" | grep -e "--classic" >/dev/null; then
cd _srcdist;
else
cd _build;
fi
- cd _build;
- make
- if [ -z "$BUILDONLY" ]; then
if [ -n "$CROSS_COMPILE" ]; then
Expand Down
3 changes: 1 addition & 2 deletions Configurations/README
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ In each table entry, the following keys are significant:
some options. In this case, the first
string in the list is the name of the build
scheme.
Currently recognised build schemes are
"unixmake" and "unified".
Currently recognised build scheme is "unified".
For the "unified" build scheme, this item
*must* be an array with the first being the
word "unified" and the second being a word
Expand Down
24 changes: 1 addition & 23 deletions Configure
Original file line number Diff line number Diff line change
Expand Up @@ -458,8 +458,6 @@ my $target="";
$config{options}="";
$config{build_type} = "release";

my $classic = 0;

my @argvcopy=@ARGV;

if (grep /^reconf(igure)?$/, @argvcopy) {
Expand Down Expand Up @@ -644,11 +642,7 @@ foreach (@argvcopy)
}
elsif (/^[-+]/)
{
if (/^--classic$/)
{
$classic=1;
}
elsif (/^--prefix=(.*)$/)
if (/^--prefix=(.*)$/)
{
$config{prefix}=$1;
die "Directory given with --prefix MUST be absolute\n"
Expand Down Expand Up @@ -904,22 +898,6 @@ $config{shared_ldflag} = "";
$target{build_scheme} = [ $target{build_scheme} ]
if ref($target{build_scheme}) ne "ARRAY";

###### TO BE REMOVED WHEN CLASSIC BUILD IS REMOVED
######
###### If the user has chosen --classic, we give it to them.
###### If they try that with an out-of-source config, we complain.
if ($target{build_scheme}->[0] eq "unified" && $classic) {
die "Can't perform a classic build out of source tree\n"
if $srcdir ne $blddir;

$target{build_scheme} = { unix => [ "unixmake" ],
windows => undef,
VMS => undef } -> {$target{build_scheme}->[1]};

die "Classic mode unavailable on this platform\n"
unless defined($target{build_scheme});
}

my ($builder, $builder_platform, @builder_opts) =
@{$target{build_scheme}};

Expand Down
Loading

0 comments on commit 45c6e23

Please sign in to comment.