Drop default.yaml file #383

raukadah · 2024-09-03T01:02:58Z

#375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file.

So we are no longer needing default.yaml file.

Depends-On: openstack-k8s-operators/ci-framework#2292

cjeanner · 2024-09-03T05:38:21Z

/lgtm

There's still the bgp.yaml to split, done via #375 and then we should be good to get the updated yamale + name consistency check (#379) in!

softwarefactory-project-zuul · 2024-09-03T05:38:30Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9ca905ca78374f288a4930da73460e92

Warning:
Change 2267 in project openstack-k8s-operators/ci-framework does not share a change queue with 383 in project openstack-k8s-operators/architecture

cjeanner · 2024-09-03T05:39:06Z

/hold

let's get tests done.

openstack-k8s-operators#375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. So we are no longer needing default.yaml file. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>

cjeanner · 2024-09-04T06:41:48Z

/hold cancel

cjeanner · 2024-09-04T07:24:30Z

/retest ci/prow/unit

openshift-ci · 2024-09-04T07:24:34Z

@cjeanner: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test images
/test unit

Use /test all to run all jobs.

In response to this:

/retest ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cjeanner · 2024-09-04T07:24:50Z

/test unit

openshift-ci · 2024-09-04T07:25:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cjeanner,raukadah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cjeanner · 2024-09-04T08:36:14Z

/override unit
There seems to be some issue with Prow. This check isn't relevant for this specific PR.

openshift-ci · 2024-09-04T08:36:20Z

@cjeanner: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

unit

Only the following failed contexts/checkruns were expected:

ci/prow/images
ci/prow/unit
pull-ci-openstack-k8s-operators-architecture-18.0.0-proposed-images
pull-ci-openstack-k8s-operators-architecture-18.0.0-proposed-unit
rdoproject.org/github-check

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override unit
There seems to be some issue with Prow. This check isn't relevant for this specific PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cjeanner · 2024-09-04T08:36:46Z

/override ci/prow/unit
There seems to be some issue with Prow. This check isn't relevant for this specific PR.

openshift-ci · 2024-09-04T08:36:52Z

@cjeanner: Overrode contexts on behalf of cjeanner: ci/prow/unit

In response to this:

/override ci/prow/unit
There seems to be some issue with Prow. This check isn't relevant for this specific PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

raukadah · 2024-09-04T08:47:37Z

recheck

raukadah · 2024-09-04T09:06:50Z

/override ci/prow/images

openshift-ci · 2024-09-04T09:06:55Z

@raukadah: Overrode contexts on behalf of raukadah: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

raukadah · 2024-09-04T09:07:33Z

recheck-gate

softwarefactory-project-zuul · 2024-09-04T09:07:49Z

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1022b38c4cc74b6482dcf3e270d3c938

✔️ noop SUCCESS in 0s

…omation Ensure we have one scenario per automation file This is in addition to a coming PR, #383. This change here is allowing to ensure we follow those practices: only one scenario per file filename matches "scenario_name.yaml" pattern

It backports following patches: openstack-k8s-operators#375 - Move automation default vars into seperate scenario files openstack-k8s-operators#383 - Drop default.yaml file openstack-k8s-operators#379 - Ensure we have one scenario per automation file openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>

It backports following patches: openstack-k8s-operators#375 - Move automation default vars into seperate scenario files openstack-k8s-operators#383 - Drop default.yaml file openstack-k8s-operators#379 - Ensure we have one scenario per automation file openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file openstack-k8s-operators#373 - NFV-HCI minor fixes Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>

Backport default.yaml split patches It backports following patches: #375 #383 #379 #384 #373 Reviewed-by: Ella Shulman <ellashulman1@gmail.com> Reviewed-by: Cédric Jeanneret

openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>

openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. openstack-k8s-operators#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>

openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>

openshift-ci bot requested review from abays and cjeanner September 3, 2024 01:03

openshift-ci bot added the approved label Sep 3, 2024

cjeanner mentioned this pull request Sep 3, 2024

Ensure we have one scenario per automation file #379

Merged

openshift-ci bot assigned cjeanner Sep 3, 2024

openshift-ci bot added the lgtm label Sep 3, 2024

openshift-ci bot added the do-not-merge/hold label Sep 3, 2024

cjeanner force-pushed the drop_defaults branch from 5f80735 to d52413e Compare September 4, 2024 06:24

openshift-ci bot removed the lgtm label Sep 4, 2024

openshift-ci bot removed the do-not-merge/hold label Sep 4, 2024

cjeanner approved these changes Sep 4, 2024

View reviewed changes

openshift-ci bot added the lgtm label Sep 4, 2024

abays mentioned this pull request Sep 4, 2024

NFV-HCI minor fixes #373

Merged

softwarefactory-project-zuul bot merged commit 2444537 into openstack-k8s-operators:main Sep 4, 2024
9 checks passed

raukadah mentioned this pull request Sep 10, 2024

Backport default.yaml split patches #394

Merged

lewisdenny mentioned this pull request Sep 11, 2024

[18.0.0-proposed] Adds missing "mode" to tasks with copy and file modules openstack-k8s-operators/ci-framework#2340

Merged

raukadah mentioned this pull request Sep 12, 2024

Use cifmw_architecture_scenario file in set va scenario openstack-k8s-operators/ci-framework#2342

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop default.yaml file #383

Drop default.yaml file #383

raukadah commented Sep 3, 2024 •

edited by cjeanner

Loading

cjeanner commented Sep 3, 2024

softwarefactory-project-zuul bot commented Sep 3, 2024

cjeanner commented Sep 3, 2024

cjeanner commented Sep 4, 2024

cjeanner commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

cjeanner commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

cjeanner commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

cjeanner commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

raukadah commented Sep 4, 2024

raukadah commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

raukadah commented Sep 4, 2024

softwarefactory-project-zuul bot commented Sep 4, 2024

Drop default.yaml file #383

Drop default.yaml file #383

Conversation

raukadah commented Sep 3, 2024 • edited by cjeanner Loading

cjeanner commented Sep 3, 2024

softwarefactory-project-zuul bot commented Sep 3, 2024

cjeanner commented Sep 3, 2024

cjeanner commented Sep 4, 2024

cjeanner commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

cjeanner commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

cjeanner commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

cjeanner commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

raukadah commented Sep 4, 2024

raukadah commented Sep 4, 2024

openshift-ci bot commented Sep 4, 2024

raukadah commented Sep 4, 2024

softwarefactory-project-zuul bot commented Sep 4, 2024

raukadah commented Sep 3, 2024 •

edited by cjeanner

Loading