Skip to content

Commit

Permalink
Merge pull request #47 from dmendiza/fix-container-image
Browse files Browse the repository at this point in the history
Remove duplicated ContainerImage
  • Loading branch information
vakwetu authored Nov 14, 2023
2 parents c704e3d + 50deccd commit d16306f
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 15 deletions.
4 changes: 0 additions & 4 deletions api/v1beta1/common_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ type BarbicanTemplate struct {
// ServiceUser - optional username used for this service to register in keystone
ServiceUser string `json:"serviceUser"`

// +kubebuilder:validation:Required
// Barbican Container Image URL (will be set to environmental default if empty)
ContainerImage string `json:"containerImage"`

// +kubebuilder:validation:Required
// MariaDB instance name
// TODO(dmendiza): Is this comment right?
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/barbican.openstack.org_barbicanapis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ spec:
description: BarbicanAPISpec defines the desired state of BarbicanAPI
properties:
containerImage:
description: Barbican Container Image URL (will be set to environmental
default if empty)
description: ContainerImage - Barbican Container Image URL (will be
set to environmental default if empty)
type: string
customServiceConfig:
description: CustomServiceConfig - customize the service config using
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ spec:
BarbicanKeystoneListener
properties:
containerImage:
description: Barbican Container Image URL (will be set to environmental
default if empty)
description: ContainerImage - Barbican Container Image URL (will be
set to environmental default if empty)
type: string
customServiceConfig:
description: CustomServiceConfig - customize the service config using
Expand Down
5 changes: 0 additions & 5 deletions config/crd/bases/barbican.openstack.org_barbicans.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -529,10 +529,6 @@ spec:
required:
- containerImage
type: object
containerImage:
description: Barbican Container Image URL (will be set to environmental
default if empty)
type: string
customServiceConfig:
description: CustomServiceConfig - customize the service config using
this parameter to change service defaults, or overwrite rendered
Expand Down Expand Up @@ -637,7 +633,6 @@ spec:
- barbicanAPI
- barbicanKeystoneListener
- barbicanWorker
- containerImage
- databaseInstance
- rabbitMqClusterName
- serviceAccount
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/barbican.openstack.org_barbicanworkers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ spec:
description: BarbicanWorkerSpec defines the desired state of BarbicanWorker
properties:
containerImage:
description: Barbican Container Image URL (will be set to environmental
default if empty)
description: ContainerImage - Barbican Container Image URL (will be
set to environmental default if empty)
type: string
customServiceConfig:
description: CustomServiceConfig - customize the service config using
Expand Down

0 comments on commit d16306f

Please sign in to comment.