Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kuttl tests #5

Merged
merged 1 commit into from
May 19, 2023
Merged

Add kuttl tests #5

merged 1 commit into from
May 19, 2023

Conversation

jparoly
Copy link
Contributor

@jparoly jparoly commented May 10, 2023 •
edited

@abays abays mentioned this pull request May 11, 2023
Open
@abays
Copy link
Contributor

abays commented May 17, 2023

To fix the CI errors here, we first need to merge #6 and then rebase this PR.

@abays abays requested review from xek and dmendiza May 17, 2023 11:14
@abays
Copy link
Contributor

abays commented May 18, 2023

To fix the CI errors here, we first need to merge #6 and then rebase this PR.

@jparoly Would you mind rebasing this PR against main now that #6 has been merged? Let's see if it fixes CI.

dmendiza
dmendiza approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@dmendiza dmendiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmendiza dmendiza merged commit 4ffa6d8 into openstack-k8s-operators:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmendiza dmendiza dmendiza approved these changes

@xek xek Awaiting requested review from xek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jparoly @abays @dmendiza