Run ceph update if part of the deployment #2349
Conversation
|
Thanks for the PR! ❤️ |
|
I'd like to testproject this before doing any change or marking as ready. |
|
This PR is stale because it has been for over 15 days with no activity. |
fmount
force-pushed
the
ceph_upgrade
branch
3 times, most recently
from
4333761
to
c6de525
Compare
|
+2 This patch looks good to me. Want to rebase it and take it out of draft ? |
Thank you @fultonj for looking at it. I'm currently trying this patch as part of unigamma in a testproject. When we have a green CI I'll post the results and we can move forward! |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e645da52ead8490f9a83d6e1e660c966 ❌ openstack-k8s-operators-content-provider FAILURE in 7m 51s |
fmount
force-pushed
the
ceph_upgrade
branch
3 times, most recently
from
b9091cb
to
137e928
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3d4c83f753f54156998703076f100e9a ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 46s |
fmount
force-pushed
the
ceph_upgrade
branch
2 times, most recently
from
4f5857f
to
be0df12
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/50a952529bc2431996df08ac79c12ac1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 35s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7ec8c233c5b446e79574bc74fc850739 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 13s |
In case we run a minor update job where Ceph is deployed, the procedure should update Ceph according to a given container tag. This is useful to verify that the combination between the target Ceph version and the target RHOSO version is still healthy. This patch introduces the playbook/tasks that are supposed to invoke the Ceph update before openstack: - it results in a noop in case the ceph container image tag is the <= of the current deployed Ceph cluster - it is skipped by default if no "ceph_update" variable is passed or it is set to false - it can be skipped by passing --skip-tags ceph_update to the playbook By doing this we have the ability to trigger a Ceph update and make sure we continue to test the combination between the two projects, but at the same time we are not introducing an hard dependency as it can easily be skipped. Jira: https://issues.redhat.com/browse/OSPRH-9697 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fultonj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 753c18d
into
openstack-k8s-operators:main
|
/cherrypick 18.0-fr1 |
|
@fmount: new pull request created: #2499 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In case we perform a minor update job where
Cephis deployed, as part of the minor update procedure we might want to updateCeph(according to a givencontainer image tag) to verify the combination between the target Ceph version and the target OpenStack version is still healthy. This patch introduces the tasks that are supposed to call theCephupdate before OpenStack:Cephclustercifmw_ceph_updatevariable is passed or it is set tofalse(which is the default)--skip-tags ceph_updateto the playbookBy doing this we have the ability to trigger a Ceph update and make sure we continue to test the combination between the two projects, but at the same time we are not introducing an hard dependency as it can easily be skipped.
Jira: https://issues.redhat.com/browse/OSPRH-9697