Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback sushy-emulator to public net if no ctlplane #2365

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Sep 19, 2024

If ctlplane network is not enabled/attached to the controller-0 node fallback the sushy.utility host record to the public net.

This allows me to configure controller with only public net:

cifmw_libvirt_manager_configuration:
  vms:
    controller:
      nets:
        - ocpbm

cifmw_networking_definition:
  instances:
    controller-0:
      networks: {}

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft September 19, 2024 18:01
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

If ctlplane network is not enabled/attached to the controller-0 node
fallback the sushy.utility host record to the public net.

This allows me to configure controller with only public net:

```
cifmw_libvirt_manager_configuration:
  vms:
    controller:
      nets:
        - ocpbm

cifmw_networking_definition:
  instances:
    controller-0:
      networks: {}
```
@hjensas hjensas force-pushed the sushy-emulator-fallback-public-net branch from 3c99fa1 to 4639357 Compare September 19, 2024 18:02
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/588608daee004310bfaf76a3513f1aa0

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 41s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 34s
build-push-container-cifmw-client TIMED_OUT in 1h 30m 31s
✔️ cifmw-molecule-reproducer SUCCESS in 18m 27s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant