-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test-operator] Move away from Jobs to Pods #2664
base: main
Are you sure you want to change the base?
Conversation
With this PR [1] the test operator dropped the usage of OCP Jobs for spawning of the test pods. This change updates the test-operator role so that it works with the new version of the test-operator that spawns test pods directly through the OCP Pods object. [1] openstack-k8s-operators/test-operator#266
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold These PRs need to be merged at the same time. The idea is to first get |
@@ -29,7 +29,7 @@ | |||
tempest_list_allowed: | |||
yaml_file: "{{ cifmw_test_operator_artifacts_basedir }}/list_allowed.yml" | |||
groups: "{{ cifmw_test_operator_default_groups }}" | |||
job: "{{ cifmw_test_operator_job_name | default(omit) }}" | |||
job: "{{ cifmw_test_operator_instance_name | default(omit) }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value is being assigned to a job
variable. I don't know if that's a wanted occurrence.
With this PR [1] the test operator dropped the usage of OCP Jobs for spawning of the test pods.
This change updates the test-operator role so that it works with the new version of the test-operator that spawns test pods directly through the OCP Pods object.
[1] openstack-k8s-operators/test-operator#266