Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Removed KubeService from API as it does not get created anymore #659

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Removed KubeService from API as it does not get created anymore #659

merged 1 commit into from
Feb 13, 2024

Conversation

jlarriba
Copy link
Contributor

No description provided.

@jlarriba jlarriba requested review from slagle, abays and fao89 February 12, 2024 08:31
@openshift-ci openshift-ci bot requested review from fultonj and olliewalsh February 12, 2024 08:31
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/386c003f6a36445bb3ce2231b88192db

❌ openstack-k8s-operators-content-provider FAILURE in 11m 35s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@jlarriba jlarriba force-pushed the kubeservice_removal branch from 172e038 to 540e3c5 Compare February 12, 2024 09:43
@fao89
Copy link
Collaborator

fao89 commented Feb 12, 2024

please run make docs to fix the CI issue

@jlarriba jlarriba force-pushed the kubeservice_removal branch from 540e3c5 to cc27a45 Compare February 12, 2024 12:06
rabi
rabi approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@rabi rabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlarriba, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 49be230 into openstack-k8s-operators:main Feb 13, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rabi rabi rabi approved these changes

@slagle slagle Awaiting requested review from slagle

@abays abays Awaiting requested review from abays

@fao89 fao89 Awaiting requested review from fao89

@fultonj fultonj Awaiting requested review from fultonj

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@rabi rabi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlarriba @fao89 @rabi