Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SRBAC by default #362

Closed
wants to merge 1 commit into from

Conversation

bshephar
Copy link
Collaborator

@bshephar bshephar commented May 8, 2024

This change enables SRBAC by default for the Heat service.

@openshift-ci openshift-ci bot requested review from abays and frenzyfriday May 8, 2024 22:02
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 8, 2024
@mrunge
Copy link

mrunge commented May 14, 2024

Do we know heat actually works with SRBAC enabled? There is openstack-k8s-operators/keystone-operator#395 and its revert openstack-k8s-operators/keystone-operator#415

@rabi
Copy link
Contributor

rabi commented May 14, 2024

Do we know heat actually works with SRBAC enabled? There is openstack-k8s-operators/keystone-operator#395 and its revert openstack-k8s-operators/keystone-operator#415

That issues are not related to enabling SRBAC in heat. Heat kinda does not use scope in policies, so this PR is fine. When keystone enforces scope, heat has issues as we internally need domain admin/domain user (created internally by heat) to list roles/access credentials using a domain scoped token.

This change enables SRBAC by default for the Heat service.

Signed-off-by: Brendan Shephard <bshephar@redhat.com>
@bshephar
Copy link
Collaborator Author

We merged this one instead:
#374

@bshephar bshephar closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants