Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tlse] add TLS status config, func to return server list and tls support #192

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[tlse] add TLS status config, func to return server list and tls support #192

merged 1 commit into from
Mar 8, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Mar 6, 2024 •
edited by openshift-ci bot

Adds a TLSSupport to the memcached status which reflects if the instance got configured with TLS. Same flag was also introduced to mariadbdatabase a while back.
Also

  • adds functions to return the memcached server list and the status of tls support, which can be used for clients for easy consumption. They could be used as an intermediate step for WIP ServiceTransport CR to connect to services #190
  • creates the service list for memcached fqdn svc hostnames to be able to use fqdn hostnames in tls certs.

Jira: OSPRH-5283

@openshift-ci openshift-ci bot added the approved label Mar 6, 2024
@stuggi stuggi requested a review from Deydra71 March 6, 2024 16:14
stuggi added a commit to stuggi/keystone-operator that referenced this pull request Mar 6, 2024
@stuggi
[tlse] memcached tls client config
b28fd73 
Depends-On: openstack-k8s-operators/infra-operator#192

Jira: OSPRH-5283
@stuggi stuggi mentioned this pull request Mar 6, 2024
Merged
@stuggi stuggi force-pushed the memcached_tls_client_config branch 2 times, most recently from 741de4c to 7f4cd99 Compare March 7, 2024 07:46
stuggi added a commit to stuggi/keystone-operator that referenced this pull request Mar 7, 2024
@stuggi
[tlse] memcached tls client config
703f790 
Depends-On: openstack-k8s-operators/infra-operator#192

Jira: OSPRH-5283
stuggi added a commit to stuggi/keystone-operator that referenced this pull request Mar 7, 2024
@stuggi
[tlse] memcached tls client config
80a83e4 
Depends-On: openstack-k8s-operators/infra-operator#192

Jira: OSPRH-5283
@stuggi
[tlse] add TLS status config, func to return server list and tls support
2c64377 
Adds a TLSSupport to the memcached status which reflects
if the instance got configured with TLS. Same flag was also
introduced to mariadbdatabase a while back.
Also
* adds functions to return the memcached server list and the
status of tls support, which can be used for clients for easy
consumption
* creates the service list for memcached fqdn svc hostnames to
be able to use fqdn hostnames in tls certs.

Jira: OSPRH-5283
@stuggi stuggi force-pushed the memcached_tls_client_config branch from 7f4cd99 to 2c64377 Compare March 7, 2024 08:00
stuggi added a commit to stuggi/cinder-operator that referenced this pull request Mar 7, 2024
@stuggi
[tlse] memcached tls client config
014e0ee 
Depends-On: openstack-k8s-operators/infra-operator#192

Jira: OSPRH-5283
stuggi added a commit to stuggi/neutron-operator that referenced this pull request Mar 7, 2024
@stuggi
[tlse] memcached tls client config
17e1313 
Depends-On: openstack-k8s-operators/infra-operator#192

Jira: OSPRH-5283
@stuggi stuggi removed the request for review from frenzyfriday March 7, 2024 09:02
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/749496900a4d40f184290007e9bab7c9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 20s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 5m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 10m 07s

@stuggi
Copy link
Contributor Author

stuggi commented Mar 7, 2024

recheck

stuggi added a commit to stuggi/keystone-operator that referenced this pull request Mar 7, 2024
@stuggi
[tlse] memcached tls client config
bd4d3e8 
Depends-On: openstack-k8s-operators/infra-operator#192

Jira: OSPRH-5283
stuggi added a commit to stuggi/keystone-operator that referenced this pull request Mar 7, 2024
@stuggi
[tlse] memcached tls client config
7910bc6 
Depends-On: openstack-k8s-operators/infra-operator#192

Jira: OSPRH-5283
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fd6c1848d25544a1bba509abf82d2669

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 35s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 5m 15s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 12m 20s

@stuggi
Copy link
Contributor Author

stuggi commented Mar 7, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5b9c08f8a36d40ca8d3b4bf1a1e619c8

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 39s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 05m 31s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 30m 35s

@stuggi
Copy link
Contributor Author

stuggi commented Mar 7, 2024

recheck

olliewalsh
olliewalsh approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eaf5876 into openstack-k8s-operators:main Mar 8, 2024
7 checks passed
stuggi added a commit to stuggi/keystone-operator that referenced this pull request Mar 8, 2024
@stuggi
[tlse] memcached tls client config
469d596 
Depends-On: openstack-k8s-operators/infra-operator#192

Jira: OSPRH-5283
stuggi added a commit to stuggi/infra-operator that referenced this pull request Mar 12, 2024
@stuggi
[testhelper] update serverList and serverListWithInet for fqdn
684a24d 
For tls, in openstack-k8s-operators#192
changed the server lists to contain the svc fqdn, but missed to
update the test helpers.
stuggi added a commit to stuggi/infra-operator that referenced this pull request Mar 12, 2024
@stuggi
[testhelper] update serverList and serverListWithInet for fqdn
68c7255 
For tls, in openstack-k8s-operators#192
changed the server lists to contain the svc fqdn, but missed to
update the test helpers.
stuggi added a commit to stuggi/infra-operator that referenced this pull request Mar 12, 2024
@stuggi
[memcached] add funcs to return quoted serverList and update test hel…
75ff147 
…pers

For tls, in openstack-k8s-operators#192
changed the server lists to contain the svc fqdn, but missed to
update the test helpers.
stuggi added a commit to stuggi/infra-operator that referenced this pull request Mar 12, 2024
@stuggi
[memcached] add funcs to return quoted serverList and update test hel…
c486fa4 
…pers

For tls, in openstack-k8s-operators#192
changed the server lists to contain the svc fqdn, but missed to
update the test helpers.
stuggi added a commit to stuggi/infra-operator that referenced this pull request Mar 12, 2024
@stuggi
[memcached] add funcs to return quoted serverList and update test hel…
9ad2d60 
…pers

For tls, in openstack-k8s-operators#192
changed the server lists to contain the svc fqdn, but missed to
update the test helpers.
stuggi added a commit to stuggi/infra-operator that referenced this pull request Mar 12, 2024
@stuggi
[memcached] add funcs to return quoted serverList and update test hel…
041b81b 
…pers

For tls, in openstack-k8s-operators#192
changed the server lists to contain the svc fqdn, but missed to
update the test helpers.
@stuggi stuggi mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliewalsh olliewalsh olliewalsh approved these changes

@dciabrin dciabrin Awaiting requested review from dciabrin

@dprince dprince Awaiting requested review from dprince

@Deydra71 Deydra71 Awaiting requested review from Deydra71

Assignees

@olliewalsh olliewalsh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stuggi @olliewalsh