Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update structured logging #305

Merged
merged 1 commit into from
Jun 5, 2024
Merged

update structured logging #305

merged 1 commit into from
Jun 5, 2024

Conversation

pinikomarov
Copy link
Contributor

@pinikomarov pinikomarov commented Sep 3, 2023 •
edited

This automatically adds additional fields like reconcile_id etc.. from the controller context.

before :

2023-05-18T01:53:14+03:00 INFO controllers.KeystoneAPI Reconciled Service init successfully

after:

2023-10-15T02:22:33+03:00 INFO Controllers.KeystoneAPI Reconciling Service {"controller": "k eystoneapi", "controllerGroup": "keystone.openstack.org", "controllerKind": "KeystoneAPI", "KeystoneAPI": {"name":"keystone","namespace":"openstack"}, "namespace": "openstack", "name": "keystone", "reconcileID" : "30b247eb-4538-47d1-89a6-b877816a1103"}

*by using per reconcile function respective logger objects, the intention is to lay the ground for parallel reconciliation in future and avoid race conditions as ctx objects are reconcile run specific.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2023

Hi @pinikomarov. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pinikomarov pinikomarov marked this pull request as ready for review September 13, 2023 22:25
@pinikomarov pinikomarov force-pushed the structured_logging branch 2 times, most recently from 32f5f50 to 8ac6001 Compare October 24, 2023 12:05
@pinikomarov pinikomarov force-pushed the structured_logging branch 3 times, most recently from 57e8ec5 to dd1053d Compare November 7, 2023 14:43
@pinikomarov
Copy link
Contributor Author

@dprince @olliewalsh can you review please ?

abays
abays reviewed Jan 18, 2024
View reviewed changes
controllers/keystoneapi_controller.go Outdated
)
if err != nil {
return ctrl.Result{}, err
}

// Always patch the instance status when exiting this function so we can persist any changes.
defer func() {
// update the Ready condition based on the sub conditions
// updatehe Ready condition based on the sub conditions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/updatehe/update the/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks , fixed that and rebased

@stuggi
Copy link
Contributor

stuggi commented Feb 9, 2024

@pinikomarov this needs a rebase

@pinikomarov
Copy link
Contributor Author

rebased

@abays
Copy link
Contributor

abays commented Feb 21, 2024

rebased

Needs another rebase again :(

@pinikomarov
Copy link
Contributor Author

rebased

@abays
Copy link
Contributor

abays commented Feb 21, 2024

/ok-to-test

stuggi
stuggi approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stuggi
Copy link
Contributor

stuggi commented Apr 22, 2024

/test keystone-operator-build-deploy-kuttl

@stuggi
Copy link
Contributor

stuggi commented Apr 29, 2024

needs rebase

@openshift-ci openshift-ci bot removed the lgtm label Apr 30, 2024
@pinikomarov
Copy link
Contributor Author

rebased

@stuggi
Copy link
Contributor

stuggi commented Jun 3, 2024

@pinikomarov there is one pre-commit issue which needs to be fixed to get this in

@pinikomarov
Copy link
Contributor Author

fixed unussed ctx failing the precommit check

@pinikomarov
Copy link
Contributor Author

oh I see now it's failing on :
operator-lint: ./main.go:136:44: too many arguments in call to (&controllers.KeystoneServiceReconciler{…}).SetupWithManager

@pinikomarov pinikomarov force-pushed the structured_logging branch 2 times, most recently from ae959a6 to 2d03fd1 Compare June 4, 2024 10:20
@pinikomarov
rebase
8bf05c0 
fix KeystoneServiceReconciler unused ctx param

fix KeystoneServiceReconciler unused ctx param2

fix KeystoneAPIReconciler unused ctx param
@pinikomarov
Copy link
Contributor Author

@stuggi I believe fixes (and rebase) are done

stuggi
stuggi approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pinikomarov, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8ee0ece into openstack-k8s-operators:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays left review comments

@stuggi stuggi stuggi approved these changes

@dprince dprince Awaiting requested review from dprince

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@stuggi stuggi

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pinikomarov @stuggi @abays @openshift-merge-robot