check for galera service list before proceeding #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zzzeek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
recheck |
KUTTL test failure could be legitimate: |
the 03-cleanup-keystoneendpoint is supposed to remove the placement endpoint. 03-assert sees the finalizer still there. my code change here has not affected deletes or finalizers at all, so looks like it's taking too long to remove the finalizer. |
|
also I think we just saw this same error with a previous PR I was getting merged and it auto-cleared |
identical failure in this job on April 2: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openstack-k8s-operators_keystone-operator/393/pull-ci-openstack-k8s-operators-keystone-operator-main-keystone-operator-build-deploy-kuttl/1775150559943200768 |
|
/retest |
|
the new message is in the logs, right here: it hit the error three times, then applied the hostname: so it would seem this condition is common. Which might mean, we hit this error all the time and it just causes the reconcile to happen again anyway, and this was not actually a "problem" even though not that smooth? I'll look in an older run of this job and see what's there for this. |
|
yup, this is common and non-fatal here's an older run with the older version of the error: it's messier, but gets to the same place |
|
so that said, I would definitely merge the change in Galera and apply to all the operators, starting with the early init ones like Keystone here. just not sure if this is what leads to your dbsync condition. |
|
Okay, good to know that it's transient. But yeah, if we merge the change across all operators, we'll have to wait and observe to see if it resolves the DBSync problem. |
zzzeek
force-pushed
the
check_for_galera_services
branch
2 times, most recently
from
d8c3ab6
to
32003ca
Compare
This updates galera operator to use a version which will wait for a Service to exist before proceeding to attempt setting the galera hostname
zzzeek
force-pushed
the
check_for_galera_services
branch
from
32003ca
to
b31afb1
Compare
|
/retest |
|
/restest |
|
/retest |
|
@zzzeek Was this waiting for some MariaDB PRs to merge so that you could remove the |
|
this PR was mostly to make sure the mariadbdatabase API part of the change didnt break, the fix to mariadb is on the operator side so I think in this PR it doesnt actually take effect unless it's in openstack-operator, so bumping at this level is not critical right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates galera operator to use a version which will wait for a Service to exist before proceeding to attempt setting the galera hostname