Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cloudrc contents in openstack-config-secret #432

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented Jun 27, 2024

We are currently only creating the clouds.yaml and secure.yaml for the openstack client and not the classic cloudrc file that was usually sourced for individual clients.

This makes sense if there were parity between the openstck client and all the individual clients, but there are still missing features. For example:

  • The openstack volume service list cannot show the cluster.
  • The openstack volume service list cannot show the backend state.
  • There is no support for any of the default volume type commands: set, show, list, unset.

These are some of the ones we know about, but there could be more.

Users will need to use the old cinder client, so we should make it convenient for them by having the cloudrc available in the openstackclient pod.

This patch adds the cloudrc key in the openstack-config-secret secret to make it possible for the openstack-operator to mount it in the openstackclient pod.

We are currently only creating the `clouds.yaml` and `secure.yaml` for
the openstack client and not the classic `cloudrc` file that was usually
sourced for individual clients.

This makes sense if there were parity between the openstck client and
all the individual clients, but there are still missing features. For
example:

- The `openstack volume service list` cannot show the cluster.
- The `openstack volume service list` cannot show the backend state.
- There is no support for any of the default volume type commands: set,
  show, list, unset.

These are some of the ones we know about, but there could be more.

Users will need to use the old `cinder` client, so we should make it
convenient for them by having the `cloudrc` available in the
`openstackclient` pod.

This patch adds the `cloudrc` key in the `openstack-config-secret`
secret to make it possible for the `openstack-operator` to mount it in
the `openstackclient` pod.
Akrog added a commit to Akrog/openstack-operator that referenced this pull request Jun 27, 2024
We are currently only creating the `clouds.yaml` and `secure.yaml` in
the `openstackclient` pod, and that is enough for the openstack client,
but unfortunately this is not enough since there is no parity between
that client and the individual clients.

For example it is missing (though it has upstream patches in progress):

- The `openstack volume service list` cannot show the cluster.
- The `openstack volume service list` cannot show the backend state.
- There is no support for any of the default volume type commands: set,
  show, list, unset.

These are some of the ones we know about, but there could still be some
other missing.

Users will need to use the old `cinder` client, so we should make it
convenient for them by having the `cloudrc` available in the
`openstackclient` pod.

Depends-On: openstack-k8s-operators/keystone-operator#432
Akrog added a commit to Akrog/openstack-operator that referenced this pull request Jun 28, 2024
We are currently only creating the `clouds.yaml` and `secure.yaml` in
the `openstackclient` pod, and that is enough for the openstack client,
but unfortunately this is not enough since there is no parity between
that client and the individual clients.

For example it is missing (though it has upstream patches in progress):

- The `openstack volume service list` cannot show the cluster.
- The `openstack volume service list` cannot show the backend state.
- There is no support for any of the default volume type commands: set,
  show, list, unset.

These are some of the ones we know about, but there could still be some
other missing.

Users will need to use the old `cinder` client, so we should make it
convenient for them by having the `cloudrc` available in the
`openstackclient` pod.

Depends-On: openstack-k8s-operators/keystone-operator#432
Copy link

@ASBishop ASBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ASBishop
Copy link

@frenzyfriday can you please approve this? It's needed for openstack-k8s-operators/openstack-operator#890

@ASBishop
Copy link

ASBishop commented Jul 1, 2024

/assign @frenzyfriday

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, ASBishop, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 287a91f into main Jul 17, 2024
9 checks passed
vakwetu pushed a commit to vakwetu/openstack-operator that referenced this pull request Sep 12, 2024
We are currently only creating the `clouds.yaml` and `secure.yaml` in
the `openstackclient` pod, and that is enough for the openstack client,
but unfortunately this is not enough since there is no parity between
that client and the individual clients.

For example it is missing (though it has upstream patches in progress):

- The `openstack volume service list` cannot show the cluster.
- The `openstack volume service list` cannot show the backend state.
- There is no support for any of the default volume type commands: set,
  show, list, unset.

These are some of the ones we know about, but there could still be some
other missing.

Users will need to use the old `cinder` client, so we should make it
convenient for them by having the `cloudrc` available in the
`openstackclient` pod.

Depends-On: openstack-k8s-operators/keystone-operator#432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants