Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service Endpoint Validate() method #505

Merged
merged 1 commit into from
May 22, 2024

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented May 7, 2024

This method can e.g. be used in webhooks to validate if the configuration in the CR is correct.

@stuggi
Copy link
Contributor Author

stuggi commented May 7, 2024

/hold until after beta freeze

stuggi added a commit to stuggi/keystone-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/keystone-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/keystone-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/keystone-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/placement-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/placement-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/keystone-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/nova-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/ironic-operator that referenced this pull request May 7, 2024
stuggi added a commit to stuggi/keystone-operator that referenced this pull request May 8, 2024
stuggi added a commit to stuggi/placement-operator that referenced this pull request May 8, 2024
stuggi added a commit to stuggi/ironic-operator that referenced this pull request May 8, 2024
This method can e.g. be used in webhooks to validate if the
configuration in the CR is correct.
stuggi added a commit to stuggi/keystone-operator that referenced this pull request May 8, 2024
stuggi added a commit to stuggi/placement-operator that referenced this pull request May 8, 2024
stuggi added a commit to stuggi/nova-operator that referenced this pull request May 8, 2024
stuggi added a commit to stuggi/ironic-operator that referenced this pull request May 8, 2024
stuggi added a commit to stuggi/barbican-operator that referenced this pull request May 8, 2024
stuggi added a commit to stuggi/neutron-operator that referenced this pull request May 8, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stuggi stuggi merged commit d6e0308 into openstack-k8s-operators:main May 22, 2024
2 checks passed
stuggi added a commit to stuggi/placement-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/nova-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/keystone-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/ironic-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/barbican-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/neutron-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/glance-operator that referenced this pull request May 22, 2024
Updates webhook to be able to be call from the openstack-operator
webhook on the GlanceSpecCore, like for other operators in [1].

Also adds check for valid service override endpoint type on create
and update.

Depends-On: openstack-k8s-operators/lib-common#505

[1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181
stuggi added a commit to stuggi/cinder-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/heat-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/manila-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/swift-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/designate-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/octavia-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/nova-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/swift-operator that referenced this pull request May 22, 2024
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/placement-operator that referenced this pull request May 22, 2024
stuggi added a commit to stuggi/manila-operator that referenced this pull request May 23, 2024
stuggi added a commit to stuggi/heat-operator that referenced this pull request May 23, 2024
stuggi added a commit to stuggi/swift-operator that referenced this pull request May 23, 2024
stuggi added a commit to stuggi/cinder-operator that referenced this pull request May 23, 2024
stuggi added a commit to stuggi/nova-operator that referenced this pull request Jun 3, 2024
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/nova-operator that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants