Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nova-api probe timeout #381

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented May 22, 2023

In tempest we saw[1] that a longer nova API request from tempest can block the pod probes resulting in a pod restart. So this patch bumps the timeout values of the probes to see if it mitigates the issue or not.

[1] #377 (comment)

In tempest we saw that a longer nova API request from tempest can block
the pod probes resulting in a pod restart. So this patch bumps the
timeout values of the probes to see if it mitigates the issue or not.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gibizer
Copy link
Contributor Author

gibizer commented May 22, 2023

/test-all

@gibizer
Copy link
Contributor Author

gibizer commented May 22, 2023

/test-all

@gibizer
Copy link
Contributor Author

gibizer commented May 22, 2023

/test all

@gibizer
Copy link
Contributor Author

gibizer commented May 22, 2023

/retest all
One tempest passed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

@gibizer: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test functional
  • /test images
  • /test precommit-check

The following commands are available to trigger optional jobs:

  • /test nova-operator-build-deploy
  • /test nova-operator-build-deploy-tempest

Use /test all to run all jobs.

In response to this:

/retest all
One tempest passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gibizer
Copy link
Contributor Author

gibizer commented May 22, 2023

/test nova-operator-build-deploy-tempest

@gibizer
Copy link
Contributor Author

gibizer commented May 23, 2023

/test nova-operator-build-deploy-tempest

tempest failed but that is actually a tempest issue. I try to fix that in https://review.opendev.org/c/openstack/tempest/+/883892 but if the test_list_all_networks runs early when no network is created yet by other test cases then it will fail. So we should probably skiplist this test.

No nova-api container restart was observed during the run so I considers this tempest run a success from this PR perspective.

I also noticed that currently tempest is run with parallelism of 15. This is will not work later when we enable scenario tests.

@gibizer
Copy link
Contributor Author

gibizer commented May 23, 2023

/test nova-operator-build-deploy-tempest
tempest success 3/3

@gibizer
Copy link
Contributor Author

gibizer commented May 23, 2023

@gibizer
Copy link
Contributor Author

gibizer commented May 23, 2023

4/4 success

@gibizer gibizer marked this pull request as ready for review May 23, 2023 15:34
@openshift-ci openshift-ci bot requested review from kk7ds and mrkisaolamb May 23, 2023 15:34
Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks gibi, lets proceed with this for now and see if the ci stablises.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b03835b into openstack-k8s-operators:main May 23, 2023
@gibizer gibizer deleted the nova-api-liveness-tempest branch August 25, 2023 13:23
SeanMooney added a commit to SeanMooney/glance-operator that referenced this pull request Apr 24, 2024
when deploying locally in crc glance can crashloop
indefintly because the readiness and liveness probe
were set to strictly.

The nova-operator relaxed the probes becuase of tempest failures
in openstack-k8s-operators/nova-operator#381

This change updates the glance values to match.
SeanMooney added a commit to SeanMooney/keystone-operator that referenced this pull request Apr 24, 2024
When deploying locally in crc keystone can crashloop
indefintly because the readiness and liveness probe
were set to strictly.

The nova-operator relaxed the probes becuase of tempest failures
in openstack-k8s-operators/nova-operator#381

This change updates the keystone values to match.
SeanMooney added a commit to SeanMooney/placement-operator that referenced this pull request Apr 24, 2024
When deploying locally in crc placement can crashloop
indefintly because the readiness and liveness probe
were set to strictly.

The nova-operator relaxed the probes becuase of tempest failures
in openstack-k8s-operators/nova-operator#381

This change updates the placement values to match.
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/placement-operator that referenced this pull request Apr 25, 2024
When deploying locally in crc placement can crashloop
indefintly because the readiness and liveness probe
were set to strictly.

The nova-operator relaxed the probes becuase of tempest failures
in openstack-k8s-operators/nova-operator#381

This change updates the placement values to match.
SeanMooney added a commit to SeanMooney/glance-operator that referenced this pull request Apr 25, 2024
when deploying locally in crc glance can crashloop
indefintly because the readiness and liveness probe
were set to strictly.

The nova-operator relaxed the probes becuase of tempest failures
in openstack-k8s-operators/nova-operator#381

This change updates the glance values to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants