-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disconnected network environments #483
Support disconnected network environments #483
Conversation
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/8f354fc319084de98862d086bf1e5fd4 ❌ nova-operator-content-provider FAILURE in 9m 04s |
Re the failed CI here. It seems we run 'make bundle' before our operator builds complete in CI. This should resolve the issue: openshift/release#4204 |
/retest |
Prow jobs are now fixed. The RDO jobs fail with: Error generating bundle manifests: error resolving image: Get "https://38.102.83.202:5001/v2/\": http: server gave HTTP response to HTTPS client" |
recheck node hold |
Build failed (check pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/6da13e1955f248079e1b3f551bc6fc4b ❌ nova-operator-content-provider FAILURE in 8m 56s |
cc553c5
to
41e2e78
Compare
/test nova-operator-build-deploy |
value: quay.io/podified-antelope-centos9/openstack-nova-conductor:current-podified | ||
- name: NOVA_METADATA_IMAGE_URL_DEFAULT | ||
- name: RELATED_IMAGE_NOVA_METADATA_IMAGE_URL_DEFAULT | ||
value: quay.io/podified-antelope-centos9/openstack-nova-api:current-podified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that we have 2 variables referring to the same container image actually causes a validation warning when using 'generate bundle'. We should consider a follow up here to get rid of RELATED_IMAGE_NOVA_METADATA_IMAGE_URL_DEFAULT as it would always be the same as RELATED_IMAGE_NOVA_API_IMAGE_URL_DEFAULT I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I think we can drop NOVA_METADATA_IMAGE_URL_DEFAULT in a followup
This PR adds support for installing the operator in disconnected network environments. To build with image-digests set USE_IMAGE_DIGESTS=true before running make bundle. For Prow jobs we are enabling this via .prow-ci.env This drops the old logic from create_bundle.sh which has been broken with operator-sdk's make bundle for some time. (NOTE: this currently requires a secure registry)
/retest |
/test nova-operator-build-deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm not sure if we are OK to land this or it needs other changes to land first. Let me know if we want to land this and I will approve it.
value: quay.io/podified-antelope-centos9/openstack-nova-conductor:current-podified | ||
- name: NOVA_METADATA_IMAGE_URL_DEFAULT | ||
- name: RELATED_IMAGE_NOVA_METADATA_IMAGE_URL_DEFAULT | ||
value: quay.io/podified-antelope-centos9/openstack-nova-api:current-podified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I think we can drop NOVA_METADATA_IMAGE_URL_DEFAULT in a followup
|
||
# FIXME: display any ENV variables once we have offline support implemented | ||
#grep -A1 IMAGE_URL_DEFAULT "${CLUSTER_BUNDLE_FILE}" | ||
USE_IMAGE_DIGESTS=true VERSION=$RELEASE_VERSION IMG=${REGISTRY}/${BASE_IMAGE}:${GITHUB_SHA} make bundle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that we can simplify the build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dprince confirmed over slack that this has no other dependencies. So as the CI is green and I have noting against the content, I approve it now.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, gibizer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9ef16ea
into
openstack-k8s-operators:main
This PR adds support for installing the operator in disconnected network environments.