Update novaapi, novametadata and novanovncproxy to use service override #489

stuggi · 2023-08-10T15:07:39Z

Removes creation of routes. Those get done in the openstack-operator. Via service overrides the openstack-operator customize the services for the endpoints to the desired state specified in the ctlplane CR using externalEndpoints or the service override in the service template.

Jira: OSP-26690

Depends-On: openstack-k8s-operators/lib-common#313

openshift-ci · 2023-08-10T15:07:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Creates the route for the nova components, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/nova-operator#489 Jira: OSP-26690

softwarefactory-project-zuul · 2023-08-10T15:19:35Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/dd435609f3f24b7e8f8aa34d9c0229b6

❌ nova-operator-content-provider FAILURE in 10m 17s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job nova-operator-content-provider

Creates the route for the nova components, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/nova-operator#489 Jira: OSP-26690

stuggi · 2023-08-10T15:41:58Z

controllers/novanovncproxy_controller.go

-		endpoint.EndpointInternal: {Port: novncproxy.NoVNCProxyPort},
+	var ports = map[service.Endpoint]endpoint.Data{
+		service.EndpointPublic:   {Port: novncproxy.NoVNCProxyPort},
+		service.EndpointInternal: {Port: novncproxy.NoVNCProxyPort},


wondering if there is the need for vncproxy to on the internal network. pods should probably be confgured to be attached via multus to the internal api network

Creates the route for the nova components, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/nova-operator#489 Jira: OSP-26690

stuggi · 2023-08-14T13:55:41Z

test/functional/novaexternalcompute_controller_test.go

@@ -41,7 +41,7 @@ func CreateNovaCellAndEnsureReady(cell CellNames) {
 	th.SimulateJobSuccess(cell.CellDBSyncJobName)
 	th.SimulateStatefulSetReplicaReady(cell.ConductorStatefulSetName)

-	SimulateNoVNCProxyRouteIngress(cell1.CellName.Name, cell1.CellName.Namespace)
+	//SimulateNoVNCProxyRouteIngress(cell1.CellName.Name, cell1.CellName.Namespace)


@gibizer wondering what you think would be best for the externalcompute getting the vnc endpoint. right now it checks for the route [1], the externalcompute could check the novncproxy CR. either the host/url could be stored in the status, or it could get the endpointURL from the override and take the the novncproxy service.
[1] https://github.com/openstack-k8s-operators/nova-operator/blob/main/controllers/novaexternalcompute_controller.go#L461-L476

softwarefactory-project-zuul · 2023-08-14T13:57:29Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6975d5a38b6f4eabb845f259d21ed1a7

❌ nova-operator-content-provider FAILURE in 7m 55s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job nova-operator-content-provider

Creates the route for the nova components, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/nova-operator#489 Jira: OSP-26690

Removes creation of routes. Those get done in the openstack-operator. Via service overrides the openstack-operator customize the services for the endpoints to the desired state specified in the ctlplane CR using externalEndpoints or the service override in the service template. Jira: OSP-26690 Depends-On: openstack-k8s-operators/lib-common#313

softwarefactory-project-zuul · 2023-08-17T07:44:45Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/776502422a76444985e14335ffa34d8c

❌ nova-operator-content-provider FAILURE in 12m 18s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job nova-operator-content-provider

openshift-ci · 2023-08-17T15:20:02Z

@stuggi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/functional	`1b769dd`	link	true	`/test functional`
ci/prow/nova-operator-build-deploy	`1b769dd`	link	false	`/test nova-operator-build-deploy`
ci/prow/nova-operator-build-deploy-tempest	`1b769dd`	link	false	`/test nova-operator-build-deploy-tempest`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2023-08-18T22:32:44Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Creates the route for the nova components, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/nova-operator#489 Jira: OSP-26690

stuggi · 2023-09-12T09:42:16Z

closing in favor of #522

Creates the route for the nova components, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/nova-operator#489 Jira: OSP-26690

openshift-ci bot requested review from jamepark4 and SeanMooney August 10, 2023 15:07

openshift-ci bot added the approved label Aug 10, 2023

stuggi mentioned this pull request Aug 10, 2023

Create several services route and svc endpoint overrides openstack-k8s-operators/openstack-operator#416

Closed

stuggi requested review from gibizer and removed request for jamepark4 August 10, 2023 15:13

stuggi commented Aug 10, 2023

View reviewed changes

openshift-merge-robot added the needs-rebase label Aug 12, 2023

stuggi force-pushed the handle_ingress branch from baf4540 to 1f5ce03 Compare August 14, 2023 13:48

openshift-merge-robot removed the needs-rebase label Aug 14, 2023

stuggi commented Aug 14, 2023

View reviewed changes

openshift-merge-robot added the needs-rebase label Aug 16, 2023

stuggi force-pushed the handle_ingress branch from 1f5ce03 to 96a1c83 Compare August 17, 2023 07:31

openshift-merge-robot removed the needs-rebase label Aug 17, 2023

openshift-merge-robot added the needs-rebase label Aug 18, 2023

stuggi closed this Sep 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update novaapi, novametadata and novanovncproxy to use service override #489

Update novaapi, novametadata and novanovncproxy to use service override #489

stuggi commented Aug 10, 2023 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Aug 10, 2023

softwarefactory-project-zuul bot commented Aug 10, 2023

stuggi Aug 10, 2023

stuggi Aug 14, 2023

softwarefactory-project-zuul bot commented Aug 14, 2023

softwarefactory-project-zuul bot commented Aug 17, 2023

openshift-ci bot commented Aug 17, 2023

openshift-merge-robot commented Aug 18, 2023

stuggi commented Sep 12, 2023

Update novaapi, novametadata and novanovncproxy to use service override #489

Update novaapi, novametadata and novanovncproxy to use service override #489

Conversation

stuggi commented Aug 10, 2023 • edited by openshift-ci bot Loading

openshift-ci bot commented Aug 10, 2023

softwarefactory-project-zuul bot commented Aug 10, 2023

stuggi Aug 10, 2023

Choose a reason for hiding this comment

stuggi Aug 14, 2023

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Aug 14, 2023

softwarefactory-project-zuul bot commented Aug 17, 2023

openshift-ci bot commented Aug 17, 2023

openshift-merge-robot commented Aug 18, 2023

stuggi commented Sep 12, 2023

stuggi commented Aug 10, 2023 •

edited by openshift-ci bot

Loading