Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding patch rbac perm for serviceaccounts #810

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Adding patch rbac perm for serviceaccounts #810

merged 1 commit into from
Jul 4, 2024

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Jul 4, 2024 •
edited
Loading

We also took the opportunity and added patch to all the existing rbac
rules that had update already to avoid similar issues in the future

Resolves: https://issues.redhat.com/browse/OSPRH-8363

@openshift-ci openshift-ci bot added the approved label Jul 4, 2024
@gibizer gibizer requested a review from SeanMooney July 4, 2024 14:23
@gibizer
Copy link
Contributor Author

gibizer commented Jul 4, 2024

this is a blocker for GA. So we need to merge it on main first and then I will cherry-pick it to 18.0.0-proposed.

mrkisaolamb
mrkisaolamb approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@mrkisaolamb mrkisaolamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 4, 2024
@gibizer
Adding patch rbac perm for serviceaccounts
9a33182 
We also took the opportunity and added patch to all the existing rbac
rules that had update already to avoid similar issues in the future

Resolves: https://issues.redhat.com/browse/OSPRH-8363
@openshift-ci openshift-ci bot removed the lgtm label Jul 4, 2024
mrkisaolamb
mrkisaolamb approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@mrkisaolamb mrkisaolamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gibizer,mrkisaolamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3ace225 into openstack-k8s-operators:main Jul 4, 2024
7 checks passed
@stuggi
Copy link
Contributor

stuggi commented Jul 5, 2024

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stuggi: new pull request created: #811

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkisaolamb mrkisaolamb mrkisaolamb approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@SeanMooney SeanMooney Awaiting requested review from SeanMooney

Assignees

@mrkisaolamb mrkisaolamb

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gibizer @stuggi @openshift-cherrypick-robot @mrkisaolamb