Modify job to use metadata per cell #812

mrkisaolamb · 2024-07-05T09:49:44Z

No description provided.

SeanMooney

thansk this looks good to me
approving pending ci conformation

openshift-ci · 2024-07-05T10:18:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrkisaolamb, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SeanMooney,mrkisaolamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

softwarefactory-project-zuul · 2024-07-05T10:35:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e269c02307bb488b87860bb3d66aab45

✔️ openstack-k8s-operators-content-provider SUCCESS in 43m 01s
❌ nova-operator-kuttl RETRY_LIMIT in 19m 47s
❌ nova-operator-tempest-multinode RETRY_LIMIT in 24m 13s
❌ nova-operator-tempest-multinode-ceph RETRY_LIMIT in 25m 51s

mrkisaolamb · 2024-07-08T08:23:00Z

recheck

bogdando

lgtm

gibizer · 2024-07-08T11:28:22Z

ci/nova-operator-tempest-multinode/control_plane_hook.yaml

+
+              - op: replace
+                path: /spec/nova/template/cellTemplates/cell1/metadataServiceTemplate/enabled
+                value: true


wouldn't we need to also disable metadata at the top level too?

hm, I thought cell0 is the top level :)

so it should be /spec/nova/template/metadataServiceTemplate/enabled instead of cell0 path (that is a special celll, should not run computes, nor metadata service for them, right?)

/spec/nova/template/metadataServiceTemplate/enabled is the top level yes.
you are right cell0 should not have computes and therefore no point to run metadata in it. The operator also rejects it

nova-operator/api/v1beta1/novametadata_webhook.go

Lines 136 to 142 in 3ace225

func (r *NovaMetadataTemplate) ValidateCell0(basePath *field.Path) field.ErrorList {

var errors field.ErrorList

if *r.Enabled {

errors = append(

errors,

field.Invalid(

basePath.Child("enabled"), *r.Enabled, "should be false for cell0"),

no, cell0 is different than top lvl so that was reason why I go with explicit disabling on cell0 but forgot disable for top lvl, also I correct operation type

gibizer

looks better, thanks

softwarefactory-project-zuul · 2024-07-08T15:27:44Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ccf7d5e4e17b4aa7b301ac533097d8bb

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 15m 36s
✔️ nova-operator-kuttl SUCCESS in 45m 11s
❌ nova-operator-tempest-multinode FAILURE in 1h 11m 04s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 30m 37s

gibizer · 2024-07-09T07:32:26Z

Monday 08 July 2024  09:49:17 -0400 (0:00:00.035)       0:00:00.220 *********** 
fatal: [localhost]: FAILED! => changed=false 
  details: |-
    error: add operation does not apply: doc is missing path: "/spec/nova/template/cellTemplates/cell0/metadataServiceTemplate/enabled": missing value

https://review.rdoproject.org/zuul/build/b436ea857a464d6ba897149baae1b40e/log/controller/ci-framework-data/logs/ci_script_011_run_82_kustomize_and_update.log#37

gibizer · 2024-07-09T07:35:34Z

ci/nova-operator-tempest-multinode/control_plane_hook.yaml

+                value: true
+
+              - op: add
+                path: /spec/neutron/template/metadataServiceTemplate/enabled


this should be /spec/nova

softwarefactory-project-zuul · 2024-07-09T12:12:09Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/58610b28bc654a9b876669962e99645a

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 22m 30s
✔️ nova-operator-kuttl SUCCESS in 45m 38s
❌ nova-operator-tempest-multinode FAILURE in 1h 53m 24s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 57m 16s

SeanMooney · 2024-07-09T13:18:43Z

ci/nova-operator-tempest-multinode/control_plane_hook.yaml

+                      enabled: false
+                  cell1:
+                    metadataServiceTemplate:
+                      enabled: true


looking at the ci output we have the following annotation on the top level service

metadata:
annotations:
metallb.universe.tf/address-pool: internalapi
metallb.universe.tf/allow-shared-ip: internalapi
metallb.universe.tf/loadBalancerIPs: 172.17.0.80

i wonder if that is the problem here?

https://logserver.rdoproject.org/12/812/f5ac7314ae6ac3c88fe797be09f01c9811665b2d/github-check/nova-operator-tempest-multinode/4d74ffe/controller/ci-framework-data/logs/ci_script_011_run_82_kustomize_and_update.log

i assume we need to copy them to the cell1 defintions

ah no its simpler then that

lastTransitionTime: "2024-07-09T11:23:35Z"
message: DB creation failed for cell0(accountName is empty),cell1(accountName
is empty)
reason: Error
severity: Error
status: "False"
type: NovaAllCellDBReady

lastTransitionTime: "2024-07-09T11:23:35Z"
message: NovaCell creation waits for DB creation for cell0,cell1
reason: Init
severity: Warning
status: "False"
type: NovaAllCellReady

lastTransitionTime: "2024-07-09T11:23:36Z"
message: All message busses created successfully
reason: Ready
status: "True"
type: NovaAllCellsMQReady

https://logserver.rdoproject.org/12/812/f5ac7314ae6ac3c88fe797be09f01c9811665b2d/github-check/nova-operator-tempest-multinode/4d74ffe/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/crs/nova.nova.openstack.org/nova.yaml

SeanMooney · 2024-07-09T13:31:42Z

the ceph job failure look to be DNS related

https://logserver.rdoproject.org/12/812/f5ac7314ae6ac3c88fe797be09f01c9811665b2d/github-check/nova-operator-tempest-multinode-ceph/050407b/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tempest-tests-zd8w6/logs/tempest-tests-tests-runner.log

but maybe its something else but that is not related to this patch

softwarefactory-project-zuul · 2024-07-09T18:16:18Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1290a25d874949389fa027bf7c73fef1

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 17m 25s
✔️ nova-operator-kuttl SUCCESS in 44m 40s
❌ nova-operator-tempest-multinode FAILURE in 1h 45m 32s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 32m 35s

softwarefactory-project-zuul · 2024-07-10T12:11:40Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a282815a39bc4d72b9c3f84c9827655b

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 33m 20s
✔️ nova-operator-kuttl SUCCESS in 43m 53s
❌ nova-operator-tempest-multinode FAILURE in 2h 20m 41s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 20m 50s

softwarefactory-project-zuul · 2024-07-10T21:18:40Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d78540be1151424e9888c6f1c2016719

✔️ openstack-k8s-operators-content-provider SUCCESS in 5h 25m 36s
✔️ nova-operator-kuttl SUCCESS in 45m 41s
❌ nova-operator-tempest-multinode FAILURE in 2h 33m 27s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 48m 53s

softwarefactory-project-zuul · 2024-07-11T20:19:05Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bf8ac68e6124410082be1c1dabde46cd

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 56m 50s
✔️ nova-operator-kuttl SUCCESS in 45m 24s
❌ nova-operator-tempest-multinode FAILURE in 2h 17m 37s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 30m 58s

softwarefactory-project-zuul · 2024-07-12T12:35:34Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b7eb5aebf22744819f1136962e3795ca

❌ openstack-k8s-operators-content-provider MERGE_CONFLICT in 1m 07s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

SeanMooney · 2024-07-12T13:26:30Z

ci/nova-operator-tempest-multinode/ci_fw_vars.yaml

+  - name: 62 Kustomize ControlPlane
+    type: playbook
+    source: pre_deploy_control_plane_hook.yml
+


this is incorrect

the job you are modifying is for non ceph so you should not be using the hci customisation here.

softwarefactory-project-zuul · 2024-07-12T13:48:01Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Unable to update github.com/openstack-k8s-operators/nova-operator

softwarefactory-project-zuul · 2024-07-15T14:48:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5cb8cc3698d840ad815138553db2643f

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 26m 47s
✔️ nova-operator-kuttl SUCCESS in 45m 39s
❌ nova-operator-tempest-multinode FAILURE in 1h 51m 28s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 38m 27s

openshift-ci bot requested review from bogdando and kk7ds July 5, 2024 09:49

openshift-ci bot added the approved label Jul 5, 2024

SeanMooney approved these changes Jul 5, 2024

View reviewed changes

openshift-ci bot assigned SeanMooney Jul 5, 2024

openshift-ci bot added the lgtm label Jul 5, 2024

bogdando reviewed Jul 8, 2024

View reviewed changes

gibizer requested changes Jul 8, 2024

View reviewed changes

openshift-ci bot assigned gibizer Jul 8, 2024

openshift-ci bot removed the lgtm label Jul 8, 2024

mrkisaolamb force-pushed the ci-cell-metadata branch from d6b7971 to 67248a6 Compare July 8, 2024 11:43

mrkisaolamb requested a review from gibizer July 8, 2024 11:47

mrkisaolamb force-pushed the ci-cell-metadata branch from 67248a6 to 54934fb Compare July 8, 2024 11:56

gibizer reviewed Jul 8, 2024

View reviewed changes

gibizer requested changes Jul 9, 2024

View reviewed changes

mrkisaolamb force-pushed the ci-cell-metadata branch 2 times, most recently from 7cbd9c6 to f5ac731 Compare July 9, 2024 07:40

SeanMooney reviewed Jul 9, 2024

View reviewed changes

mrkisaolamb force-pushed the ci-cell-metadata branch from f5ac731 to 60a4c26 Compare July 9, 2024 13:56

mrkisaolamb force-pushed the ci-cell-metadata branch from 60a4c26 to 9c4d3d4 Compare July 10, 2024 08:01

mrkisaolamb force-pushed the ci-cell-metadata branch from 9c4d3d4 to cfe7a2c Compare July 10, 2024 15:51

mrkisaolamb force-pushed the ci-cell-metadata branch from cfe7a2c to 7b1fa9d Compare July 11, 2024 14:51

mrkisaolamb force-pushed the ci-cell-metadata branch from 7b1fa9d to 231fe94 Compare July 12, 2024 11:51

SeanMooney reviewed Jul 12, 2024

View reviewed changes

mrkisaolamb force-pushed the ci-cell-metadata branch from 231fe94 to 785a709 Compare July 12, 2024 13:46

mrkisaolamb force-pushed the ci-cell-metadata branch from 785a709 to c06faad Compare July 15, 2024 07:19

Modify job to use metadata per cell

c7c20a4

mrkisaolamb force-pushed the ci-cell-metadata branch from c06faad to c7c20a4 Compare July 15, 2024 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify job to use metadata per cell #812

Modify job to use metadata per cell #812

mrkisaolamb commented Jul 5, 2024

SeanMooney left a comment

openshift-ci bot commented Jul 5, 2024

softwarefactory-project-zuul bot commented Jul 5, 2024

mrkisaolamb commented Jul 8, 2024

bogdando left a comment

gibizer Jul 8, 2024

bogdando Jul 8, 2024

bogdando Jul 8, 2024

gibizer Jul 8, 2024

mrkisaolamb Jul 8, 2024

gibizer left a comment

softwarefactory-project-zuul bot commented Jul 8, 2024

gibizer commented Jul 9, 2024

gibizer Jul 9, 2024

softwarefactory-project-zuul bot commented Jul 9, 2024

SeanMooney Jul 9, 2024

SeanMooney Jul 9, 2024

SeanMooney commented Jul 9, 2024

softwarefactory-project-zuul bot commented Jul 9, 2024

softwarefactory-project-zuul bot commented Jul 10, 2024

softwarefactory-project-zuul bot commented Jul 10, 2024

softwarefactory-project-zuul bot commented Jul 11, 2024

softwarefactory-project-zuul bot commented Jul 12, 2024

SeanMooney Jul 12, 2024

softwarefactory-project-zuul bot commented Jul 12, 2024

softwarefactory-project-zuul bot commented Jul 15, 2024

	func (r NovaMetadataTemplate) ValidateCell0(basePath field.Path) field.ErrorList {
	var errors field.ErrorList
	if *r.Enabled {
	errors = append(
	errors,
	field.Invalid(
	basePath.Child("enabled"), *r.Enabled, "should be false for cell0"),

Modify job to use metadata per cell #812

Are you sure you want to change the base?

Modify job to use metadata per cell #812

Conversation

mrkisaolamb commented Jul 5, 2024

SeanMooney left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 5, 2024

softwarefactory-project-zuul bot commented Jul 5, 2024

mrkisaolamb commented Jul 8, 2024

bogdando left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gibizer left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 8, 2024

gibizer commented Jul 9, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SeanMooney commented Jul 9, 2024

softwarefactory-project-zuul bot commented Jul 9, 2024

softwarefactory-project-zuul bot commented Jul 10, 2024

softwarefactory-project-zuul bot commented Jul 10, 2024

softwarefactory-project-zuul bot commented Jul 11, 2024

softwarefactory-project-zuul bot commented Jul 12, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 12, 2024

softwarefactory-project-zuul bot commented Jul 15, 2024